Re: [jdk23] RFR: 8334162: Gatherer.defaultCombiner has an erronous @see-link

2024-06-13 Thread Iris Clark
On Thu, 13 Jun 2024 16:47:43 GMT, Viktor Klang wrote: > Making sure that the Javadoc is correct for Gatherer Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19704#pullrequestreview-2116350395

[jdk23] RFR: 8334162: Gatherer.defaultCombiner has an erronous @see-link

2024-06-13 Thread Viktor Klang
Making sure that the Javadoc is correct for Gatherer - Commit messages: - Backport cff048c7354dd947a3946d262f4752a55b7e2a43 Changes: https://git.openjdk.org/jdk/pull/19704/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19704&range=00 Issue: https://bugs.openjdk.org/brows

Re: RFR: 8334162: Gatherer.defaultCombiner has an erronous @see-link [v2]

2024-06-13 Thread Jaikiran Pai
On Thu, 13 Jun 2024 10:48:15 GMT, Viktor Klang wrote: >> Erronous Javadoc reference addressed. This should be backported to 23. > > Viktor Klang has updated the pull request incrementally with two additional > commits since the last revision: > > - Tweaking the copyright year to reflect initia

Re: RFR: 8334162: Gatherer.defaultCombiner has an erronous @see-link [v2]

2024-06-13 Thread Viktor Klang
On Thu, 13 Jun 2024 01:31:46 GMT, Jaikiran Pai wrote: >> Viktor Klang has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Tweaking the copyright year to reflect initial year AND current >> - Updating copyright year > > Hello Viktor, the c

Re: RFR: 8334162: Gatherer.defaultCombiner has an erronous @see-link [v2]

2024-06-13 Thread Viktor Klang
> Erronous Javadoc reference addressed. This should be backported to 23. Viktor Klang has updated the pull request incrementally with two additional commits since the last revision: - Tweaking the copyright year to reflect initial year AND current - Updating copyright year - Chan

Re: RFR: 8334162: Gatherer.defaultCombiner has an erronous @see-link

2024-06-12 Thread Alan Bateman
On Wed, 12 Jun 2024 20:58:28 GMT, Viktor Klang wrote: > Erronous Javadoc reference addressed. This should be backported to 23. Marked as reviewed by alanb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19682#pullrequestreview-2114807878

Re: RFR: 8334162: Gatherer.defaultCombiner has an erronous @see-link

2024-06-12 Thread Jaikiran Pai
On Wed, 12 Jun 2024 20:58:28 GMT, Viktor Klang wrote: > Erronous Javadoc reference addressed. This should be backported to 23. Hello Viktor, the change looks fine to me. The copyright year on the file will need an update before integrating. - Marked as reviewed by jpai (Reviewer).

RFR: 8334162: Gatherer.defaultCombiner has an erronous @see-link

2024-06-12 Thread Viktor Klang
Erronous Javadoc reference addressed. This should be backported to 23. - Commit messages: - Updating Gatherer#defaultCombiner Javadoc to refer to Gatherer#combiner Changes: https://git.openjdk.org/jdk/pull/19682/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19682&range=00