Re: RFR: 8334490: Normalize string with locale invariant `toLowerCase()`

2024-06-20 Thread Naoto Sato
On Tue, 18 Jun 2024 18:23:12 GMT, Naoto Sato wrote: > The test library `jdk.test.lib.Platform` uses no-arg `toLowerCase()` for > string comparison, which should be avoided. Thank you for the reviews! - PR Comment: https://git.openjdk.org/jdk/pull/19775#issuecomment-2181150302

Re: RFR: 8334490: Normalize string with locale invariant `toLowerCase()`

2024-06-19 Thread Roger Riggs
On Tue, 18 Jun 2024 18:23:12 GMT, Naoto Sato wrote: > The test library `jdk.test.lib.Platform` uses no-arg `toLowerCase()` for > string comparison, which should be avoided. Marked as reviewed by rriggs (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19775#pullrequestrevi

Re: RFR: 8334490: Normalize string with locale invariant `toLowerCase()`

2024-06-18 Thread Lance Andersen
On Tue, 18 Jun 2024 18:23:12 GMT, Naoto Sato wrote: > The test library `jdk.test.lib.Platform` uses no-arg `toLowerCase()` for > string comparison, which should be avoided. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19775#pullrequestrevi

Re: RFR: 8334490: Normalize string with locale invariant `toLowerCase()`

2024-06-18 Thread Daniel Fuchs
On Tue, 18 Jun 2024 18:23:12 GMT, Naoto Sato wrote: > The test library `jdk.test.lib.Platform` uses no-arg `toLowerCase()` for > string comparison, which should be avoided. +1 - Marked as reviewed by dfuchs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19775#pullrequest

Re: RFR: 8334490: Normalize string with locale invariant `toLowerCase()`

2024-06-18 Thread Justin Lu
On Tue, 18 Jun 2024 18:23:12 GMT, Naoto Sato wrote: > The test library `jdk.test.lib.Platform` uses no-arg `toLowerCase()` for > string comparison, which should be avoided. LGTM - Marked as reviewed by jlu (Committer). PR Review: https://git.openjdk.org/jdk/pull/19775#pullrequest

RFR: 8334490: Normalize string with locale invariant `toLowerCase()`

2024-06-18 Thread Naoto Sato
The test library `jdk.test.lib.Platform` uses no-arg `toLowerCase()` for string comparison, which should be avoided. - Commit messages: - initial commit Changes: https://git.openjdk.org/jdk/pull/19775/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19775&range=00 Issue: