On Tue, 18 Jun 2024 18:23:12 GMT, Naoto Sato wrote:
> The test library `jdk.test.lib.Platform` uses no-arg `toLowerCase()` for
> string comparison, which should be avoided.
Thank you for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/19775#issuecomment-2181150302
On Tue, 18 Jun 2024 18:23:12 GMT, Naoto Sato wrote:
> The test library `jdk.test.lib.Platform` uses no-arg `toLowerCase()` for
> string comparison, which should be avoided.
Marked as reviewed by rriggs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19775#pullrequestrevi
On Tue, 18 Jun 2024 18:23:12 GMT, Naoto Sato wrote:
> The test library `jdk.test.lib.Platform` uses no-arg `toLowerCase()` for
> string comparison, which should be avoided.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19775#pullrequestrevi
On Tue, 18 Jun 2024 18:23:12 GMT, Naoto Sato wrote:
> The test library `jdk.test.lib.Platform` uses no-arg `toLowerCase()` for
> string comparison, which should be avoided.
+1
-
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19775#pullrequest
On Tue, 18 Jun 2024 18:23:12 GMT, Naoto Sato wrote:
> The test library `jdk.test.lib.Platform` uses no-arg `toLowerCase()` for
> string comparison, which should be avoided.
LGTM
-
Marked as reviewed by jlu (Committer).
PR Review: https://git.openjdk.org/jdk/pull/19775#pullrequest
The test library `jdk.test.lib.Platform` uses no-arg `toLowerCase()` for string
comparison, which should be avoided.
-
Commit messages:
- initial commit
Changes: https://git.openjdk.org/jdk/pull/19775/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19775&range=00
Issue: