Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v9]

2024-07-04 Thread fabioromano1
On Thu, 4 Jul 2024 12:51:47 GMT, Raffaello Giulietti wrote: >> @djelinski I also improved the `BigDecimal.sqrt()` algorithm exploiting >> `BigInteger.sqrtAndRemainder()`. > > @fabioromano1 I'll review your contribution starting sometimes next week. > Please stabilize your code until then. @rgi

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v9]

2024-07-04 Thread Raffaello Giulietti
On Thu, 27 Jun 2024 17:28:36 GMT, fabioromano1 wrote: >> Thanks. That's a very nice performance improvement, on my Windows machine >> the `testHuge...` test is about 2-3x faster, and the other 2 are slightly >> faster too. >> >> This needs a proper review for correctness, which might take a wh

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v9]

2024-06-27 Thread fabioromano1
On Mon, 24 Jun 2024 17:09:30 GMT, Daniel Jeliński wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Code optimization > > Thanks. That's a very nice performance improvement, on my Windows machine the > `testHuge...`

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v9]

2024-06-24 Thread Daniel Jeliński
On Sun, 23 Jun 2024 19:03:38 GMT, fabioromano1 wrote: >> I have implemented the Zimmermann's square root algorithm, available in >> works [here](https://inria.hal.science/inria-00072854/en/) and >> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root). >> >> The

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v9]

2024-06-23 Thread fabioromano1
> I have implemented the Zimmermann's square root algorithm, available in works > [here](https://inria.hal.science/inria-00072854/en/) and > [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root). > > The algorithm is proved to be asymptotically faster than the New