Re: [jdk23] RFR: 8335475: ClassBuilder incorrectly calculates max_locals in some cases

2024-07-08 Thread Adam Sotona
On Wed, 3 Jul 2024 02:38:58 GMT, Chen Liang wrote: > Please review this clean backport of #19981 onto JDK 23, fixing > `StackMapGenerator` generating static methods with no declared local variable > a max local of 1. Marked as reviewed by asotona (Reviewer). - PR Review: https://

[jdk23] RFR: 8335475: ClassBuilder incorrectly calculates max_locals in some cases

2024-07-02 Thread Chen Liang
Please review this clean backport of #19981 onto JDK 23, fixing `StackMapGenerator` generating static methods with no declared local variable a max local of 1. - Commit messages: - Backport 1ef34c183315b70ddc27c177a2867e30132609f5 Changes: https://git.openjdk.org/jdk/pull/19993/fi

Re: RFR: 8335475: ClassBuilder incorrectly calculates max_locals in some cases

2024-07-02 Thread Adam Sotona
On Mon, 1 Jul 2024 22:54:16 GMT, Chen Liang wrote: > Trivial fix for the bug where `StackMapGenerator` is pre-allocating the > locals incorrectly, affecting static methods with 0 locals. `StackCounter` > was not affected. Looks good to me, thanks for the fix. - Marked as reviewed

RFR: 8335475: ClassBuilder incorrectly calculates max_locals in some cases

2024-07-01 Thread Chen Liang
Trivial fix for the bug where `StackMapGenerator` is pre-allocating the locals incorrectly, affecting static methods with 0 locals. `StackCounter` was not affected. - Commit messages: - 8335475: ClassBuilder incorrectly calculates max_locals in some cases Changes: https://git.open