On Mon, 15 Jul 2024 05:53:12 GMT, Adam Sotona wrote:
> 8335820: java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java fails due
> to IllegalArgumentException: hash must be nonzero
Thank you.
-
PR Comment: https://git.openjdk.org/jdk/pull/20180#issuecomment-2228021104
On Mon, 15 Jul 2024 05:53:12 GMT, Adam Sotona wrote:
> 8335820: java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java fails due
> to IllegalArgumentException: hash must be nonzero
This is a clean backport of a P3 bug. Looks good to me for JDK 23.
-
Marked as reviewed by jpai (
8335820: java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java fails due to
IllegalArgumentException: hash must be nonzero
-
Commit messages:
- Backport 3f2636d9b71f5270c83d17dcf5d18cf907978475
Changes: https://git.openjdk.org/jdk/pull/20180/files
Webrev: https://webrevs.open
On Mon, 8 Jul 2024 14:14:02 GMT, Adam Sotona wrote:
>> Class-File API constant pool implementation requires non-zero entry hash
>> code.
>> Unfortunately current implementation computes zero hash code for specific CP
>> entries.
>>
>> This patch removes invalid and obsolete `AbstractPoolEntry:
On Mon, 8 Jul 2024 14:14:02 GMT, Adam Sotona wrote:
>> Class-File API constant pool implementation requires non-zero entry hash
>> code.
>> Unfortunately current implementation computes zero hash code for specific CP
>> entries.
>>
>> This patch removes invalid and obsolete `AbstractPoolEntry:
On Mon, 8 Jul 2024 13:57:20 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed BootstrapMethodEntryImpl::computeHashCode
>
> src/java.base/share/classes/jdk/internal/classfile/impl/BootstrapMethod
> Class-File API constant pool implementation requires non-zero entry hash code.
> Unfortunately current implementation computes zero hash code for specific CP
> entries.
>
> This patch removes invalid and obsolete `AbstractPoolEntry::phiMix`
> calculation and assures all pool entries have non-z
On Mon, 8 Jul 2024 13:09:50 GMT, Adam Sotona wrote:
> Class-File API constant pool implementation requires non-zero entry hash code.
> Unfortunately current implementation computes zero hash code for specific CP
> entries.
>
> This patch removes invalid and obsolete `AbstractPoolEntry::phiMix`
Class-File API constant pool implementation requires non-zero entry hash code.
Unfortunately current implementation computes zero hash code for specific CP
entries.
This patch removes invalid and obsolete `AbstractPoolEntry::phiMix` calculation
and assures all pool entries have non-zero hash. A
