Re: [jdk23] RFR: 8335935: Chained builders not sending transformed models to next transforms

2024-07-11 Thread Adam Sotona
On Wed, 10 Jul 2024 22:10:50 GMT, Chen Liang wrote: > Please review this non-clean backport of the bugfix in #20100 to release 23, > where ClassFile API chained builders does not emit certain elements through > downstream transforms and returns wrong builder for chaining. This backport > inclu

[jdk23] RFR: 8335935: Chained builders not sending transformed models to next transforms

2024-07-10 Thread Chen Liang
Please review this non-clean backport of the bugfix in #20100 to release 23, where ClassFile API chained builders does not emit certain elements through downstream transforms and returns wrong builder for chaining. This backport includes an additional change that rolls back a rename done in #199

Re: RFR: 8335935: Chained builders not sending transformed models to next transforms

2024-07-10 Thread Chen Liang
On Tue, 9 Jul 2024 17:34:14 GMT, Chen Liang wrote: > Please review the fix for a major transformation bug within the ClassFile > API, where certain kinds of buffered elements produced by one transform is > not sent to the next, and the "chained" (`andThen` transformation chains) > builders ret

Re: RFR: 8335935: Chained builders not sending transformed models to next transforms

2024-07-10 Thread Adam Sotona
On Tue, 9 Jul 2024 17:34:14 GMT, Chen Liang wrote: > Please review the fix for a major transformation bug within the ClassFile > API, where certain kinds of buffered elements produced by one transform is > not sent to the next, and the "chained" (`andThen` transformation chains) > builders ret

RFR: 8335935: Chained builders not sending transformed models to next transforms

2024-07-09 Thread Chen Liang
Please review the fix for a major transformation bug within the ClassFile API, where certain kinds of buffered elements produced by one transform is not sent to the next, and the "chained" (`andThen` transformation chains) builders returning the wrong builder for call chains. This is intended t