Re: RFR: 8336856: Optimize String Concat [v15]

2024-07-28 Thread Claes Redestad
On Thu, 25 Jul 2024 23:36:02 GMT, Shaojin Wen wrote: >> test/micro/org/openjdk/bench/java/lang/StringConcatGenerate.java line 47: >> >>> 45: @Measurement(iterations = 5, time = 1000, timeUnit = >>> TimeUnit.MILLISECONDS) >>> 46: @Fork(value = 3, jvmArgsAppend = >>>

Re: RFR: 8336856: Optimize String Concat [v15]

2024-07-25 Thread Shaojin Wen
On Thu, 25 Jul 2024 10:15:20 GMT, Claes Redestad wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add benchmark > > test/micro/org/openjdk/bench/java/lang/StringConcatGenerate.java line 47: > >> 45:

Re: RFR: 8336856: Optimize String Concat [v15]

2024-07-25 Thread Claes Redestad
On Thu, 25 Jul 2024 08:58:14 GMT, Shaojin Wen wrote: >> The current implementation of StringConcat is to mix the coder and length >> into a long. This operation will have some overhead for int/long/boolean >> types. We can separate the calculation of the coder from the calculation of >> the

Re: RFR: 8336856: Optimize String Concat [v15]

2024-07-25 Thread Shaojin Wen
> The current implementation of StringConcat is to mix the coder and length > into a long. This operation will have some overhead for int/long/boolean > types. We can separate the calculation of the coder from the calculation of > the length, which can improve the performance in the scenario of