Re: RFR: 8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute [v4]

2024-07-29 Thread Chen Liang
On Mon, 29 Jul 2024 12:32:10 GMT, Chen Liang wrote: >> As discussed in offline meeting, the max stack and locals information are >> part of the code attribute and not meaningful for buffered code elements. >> Computation would be costly and these see no real usage during >> transformations. Th

Re: RFR: 8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute [v4]

2024-07-29 Thread Adam Sotona
On Mon, 29 Jul 2024 12:32:10 GMT, Chen Liang wrote: >> As discussed in offline meeting, the max stack and locals information are >> part of the code attribute and not meaningful for buffered code elements. >> Computation would be costly and these see no real usage during >> transformations. Th

Re: RFR: 8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute [v4]

2024-07-29 Thread Chen Liang
> As discussed in offline meeting, the max stack and locals information are > part of the code attribute and not meaningful for buffered code elements. > Computation would be costly and these see no real usage during > transformations. Thus, the proposed solution is to move these APIs to be > C

Re: RFR: 8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute [v3]

2024-07-29 Thread Andrey Turbanov
On Mon, 29 Jul 2024 02:22:11 GMT, Chen Liang wrote: >> As discussed in offline meeting, the max stack and locals information are >> part of the code attribute and not meaningful for buffered code elements. >> Computation would be costly and these see no real usage during >> transformations. Th

Re: RFR: 8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute [v3]

2024-07-29 Thread Adam Sotona
On Mon, 29 Jul 2024 02:22:11 GMT, Chen Liang wrote: >> As discussed in offline meeting, the max stack and locals information are >> part of the code attribute and not meaningful for buffered code elements. >> Computation would be costly and these see no real usage during >> transformations. Th

Re: RFR: 8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute [v3]

2024-07-28 Thread Chen Liang
> As discussed in offline meeting, the max stack and locals information are > part of the code attribute and not meaningful for buffered code elements. > Computation would be costly and these see no real usage during > transformations. Thus, the proposed solution is to move these APIs to be > C

Re: RFR: 8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute [v2]

2024-07-28 Thread Chen Liang
On Mon, 29 Jul 2024 00:37:21 GMT, ExE Boss wrote: >> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits sinc

Re: RFR: 8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute [v2]

2024-07-28 Thread ExE Boss
On Sun, 28 Jul 2024 02:39:23 GMT, Chen Liang wrote: >> As discussed in offline meeting, the max stack and locals information are >> part of the code attribute and not meaningful for buffered code elements. >> Computation would be costly and these see no real usage during >> transformations. Th

Re: RFR: 8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute [v2]

2024-07-27 Thread Chen Liang
On Fri, 26 Jul 2024 13:17:11 GMT, Chen Liang wrote: >> src/java.base/share/classes/jdk/internal/classfile/impl/BufferedCodeBuilder.java >> line 67: >> >>> 65: this.maxLocals = Util.maxLocals(methodInfo.methodFlags(), >>> methodInfo.methodTypeSymbol()); >>> 66: if (original != n

Re: RFR: 8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute [v2]

2024-07-27 Thread Chen Liang
> As discussed in offline meeting, the max stack and locals information are > part of the code attribute and not meaningful for buffered code elements. > Computation would be costly and these see no real usage during > transformations. Thus, the proposed solution is to move these APIs to be > C

Re: RFR: 8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute

2024-07-26 Thread Chen Liang
On Fri, 26 Jul 2024 08:03:01 GMT, Adam Sotona wrote: >> As discussed in offline meeting, the max stack and locals information are >> part of the code attribute and not meaningful for buffered code elements. >> Computation would be costly and these see no real usage during >> transformations. T

Re: RFR: 8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute

2024-07-26 Thread Adam Sotona
On Thu, 25 Jul 2024 22:41:08 GMT, Chen Liang wrote: > As discussed in offline meeting, the max stack and locals information are > part of the code attribute and not meaningful for buffered code elements. > Computation would be costly and these see no real usage during > transformations. Thus,

RFR: 8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute

2024-07-25 Thread Chen Liang
As discussed in offline meeting, the max stack and locals information are part of the code attribute and not meaningful for buffered code elements. Computation would be costly and these see no real usage during transformations. Thus, the proposed solution is to move these APIs to be CodeAttribut