Re: RFR: 8341028: Do not use lambdas or method refs for verifyConstantPool [v3]

2024-10-29 Thread David M . Lloyd
On Mon, 21 Oct 2024 14:13:35 GMT, David M. Lloyd wrote: >> Currently, `ParserVerifier#verifyConstantPool` uses a `switch` to produce a >> `Runnable`, which is consumed by a `Consumer` (instantiated within >> a loop) which runs the task inside if a `try`/`catch`. We can eliminate a >> number of

Re: RFR: 8341028: Do not use lambdas or method refs for verifyConstantPool [v3]

2024-10-28 Thread Chen Liang
On Mon, 21 Oct 2024 14:13:35 GMT, David M. Lloyd wrote: >> Currently, `ParserVerifier#verifyConstantPool` uses a `switch` to produce a >> `Runnable`, which is consumed by a `Consumer` (instantiated within >> a loop) which runs the task inside if a `try`/`catch`. We can eliminate a >> number of

Re: RFR: 8341028: Do not use lambdas or method refs for verifyConstantPool [v3]

2024-10-28 Thread Andrew Dinn
On Mon, 21 Oct 2024 14:13:35 GMT, David M. Lloyd wrote: >> Currently, `ParserVerifier#verifyConstantPool` uses a `switch` to produce a >> `Runnable`, which is consumed by a `Consumer` (instantiated within >> a loop) which runs the task inside if a `try`/`catch`. We can eliminate a >> number of

Re: RFR: 8341028: Do not use lambdas or method refs for verifyConstantPool [v3]

2024-10-21 Thread David M . Lloyd
> Currently, `ParserVerifier#verifyConstantPool` uses a `switch` to produce a > `Runnable`, which is consumed by a `Consumer` (instantiated within > a loop) which runs the task inside if a `try`/`catch`. We can eliminate a > number of lambdas and method references, plus some allocation pressure,

Re: RFR: 8341028: Do not use lambdas or method refs for verifyConstantPool [v2]

2024-09-26 Thread David M . Lloyd
On Thu, 26 Sep 2024 13:41:31 GMT, Chen Liang wrote: >> David M. Lloyd has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make sure that we record every error instead of stopping at the first >> error in a particular CPE > > src/java.base/s

Re: RFR: 8341028: Do not use lambdas or method refs for verifyConstantPool [v2]

2024-09-26 Thread David M . Lloyd
> Currently, `ParserVerifier#verifyConstantPool` uses a `switch` to produce a > `Runnable`, which is consumed by a `Consumer` (instantiated within > a loop) which runs the task inside if a `try`/`catch`. We can eliminate a > number of lambdas and method references, plus some allocation pressure,

Re: RFR: 8341028: Do not use lambdas or method refs for verifyConstantPool

2024-09-26 Thread Chen Liang
On Thu, 26 Sep 2024 13:30:07 GMT, David M. Lloyd wrote: > Currently, `ParserVerifier#verifyConstantPool` uses a `switch` to produce a > `Runnable`, which is consumed by a `Consumer` (instantiated within > a loop) which runs the task inside if a `try`/`catch`. We can eliminate a > number of lam

RFR: 8341028: Do not use lambdas or method refs for verifyConstantPool

2024-09-26 Thread David M . Lloyd
Currently, `ParserVerifier#verifyConstantPool` uses a `switch` to produce a `Runnable`, which is consumed by a `Consumer` (instantiated within a loop) which runs the task inside if a `try`/`catch`. We can eliminate a number of lambdas and method references, plus some allocation pressure, in this