Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v3]

2023-10-20 Thread Lance Andersen
On Fri, 21 Apr 2023 13:33:37 GMT, Mahendra Chhipa wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comment. > > Thanks for your review comments. I will implement them and push again. > @ma

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v3]

2023-10-20 Thread Roger Riggs
On Fri, 21 Apr 2023 13:33:37 GMT, Mahendra Chhipa wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Implemented the review comment. > > Thanks for your review comments. I will implement them and push again. @mahe

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v3]

2023-04-21 Thread Mahendra Chhipa
On Thu, 20 Apr 2023 10:06:33 GMT, Mahendra Chhipa wrote: >> Test is updated to create the binary files during test execution. > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented the review comment. Thanks for yo

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v3]

2023-04-20 Thread Lance Andersen
On Thu, 20 Apr 2023 16:20:18 GMT, Daniel Fuchs wrote: > > The original version of this test was validating serialization > > compatibility with previous releases. > > The current changes seems to have removed that validation in the re-write > > of the test > > One option is to convert the vario

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v3]

2023-04-20 Thread Daniel Fuchs
On Thu, 20 Apr 2023 16:06:36 GMT, Lance Andersen wrote: > The original version of this test was validating serialization compatibility > with previous releases. > > The current changes seems to have removed that validation in the re-write of > the test > > One option is to convert the various

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v3]

2023-04-20 Thread Lance Andersen
On Thu, 20 Apr 2023 10:06:33 GMT, Mahendra Chhipa wrote: >> Test is updated to create the binary files during test execution. > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented the review comment. The original

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v3]

2023-04-20 Thread Mahendra Chhipa
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comment. - Changes: - all: https://git.openjdk.org/jdk/pull/13537/files -