Still relevant to address? /cc @PaulSandoz
-
Commit messages:
- JDK-8151531: Add notes to BaseStream.spliterator/iterator docs regarding
them being escape hatches
Changes: https://git.openjdk.org/jdk/pull/13890/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13890&range=00
On Tue, 9 May 2023 15:50:13 GMT, Viktor Klang wrote:
> Still relevant to address? /cc @PaulSandoz
I would recommend:
- using `@apiNote` (might have to be placed at the end of the documentation);
and
- say "This operation is provided ..."
-
PR Review: https://git.openjdk.org/jdk/p
> Still relevant to address? /cc @PaulSandoz
Viktor Klang has updated the pull request incrementally with one additional
commit since the last revision:
Using apiNote and rewording from method to operation
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13890/files
- new:
On Tue, 9 May 2023 16:06:12 GMT, Paul Sandoz wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Using apiNote and rewording from method to operation
>
> I would recommend:
> - using `@apiNote` (might have to be placed
On Tue, 9 May 2023 16:27:21 GMT, Viktor Klang wrote:
>> Still relevant to address? /cc @PaulSandoz
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Using apiNote and rewording from method to operation
Marked as reviewed by
On Tue, 9 May 2023 16:28:52 GMT, Paul Sandoz wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Using apiNote and rewording from method to operation
>
> Marked as reviewed by psandoz (Reviewer).
@PaulSandoz Forgot to
> Still relevant to address? /cc @PaulSandoz
Viktor Klang has updated the pull request incrementally with one additional
commit since the last revision:
Updating copyright year
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13890/files
- new: https://git.openjdk.org/jdk/p
On Wed, 10 May 2023 07:48:11 GMT, Viktor Klang wrote:
>> Still relevant to address? /cc @PaulSandoz
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updating copyright year
Marked as reviewed by psandoz (Reviewer).
---
