Re: RFR: JDK-8151531: Add notes to BaseStream.spliterator/iterator docs regarding them being escape hatches [v2]

2023-05-10 Thread Viktor Klang
On Tue, 9 May 2023 16:28:52 GMT, Paul Sandoz wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Using apiNote and rewording from method to operation > > Marked as reviewed by psandoz (Reviewer). @PaulSandoz Forgot to

Re: RFR: JDK-8151531: Add notes to BaseStream.spliterator/iterator docs regarding them being escape hatches [v2]

2023-05-09 Thread Paul Sandoz
On Tue, 9 May 2023 16:27:21 GMT, Viktor Klang wrote: >> Still relevant to address? /cc @PaulSandoz > > Viktor Klang has updated the pull request incrementally with one additional > commit since the last revision: > > Using apiNote and rewording from method to operation Marked as reviewed by

Re: RFR: JDK-8151531: Add notes to BaseStream.spliterator/iterator docs regarding them being escape hatches [v2]

2023-05-09 Thread Viktor Klang
On Tue, 9 May 2023 16:06:12 GMT, Paul Sandoz wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Using apiNote and rewording from method to operation > > I would recommend: > - using `@apiNote` (might have to be placed

Re: RFR: JDK-8151531: Add notes to BaseStream.spliterator/iterator docs regarding them being escape hatches [v2]

2023-05-09 Thread Viktor Klang
> Still relevant to address? /cc @PaulSandoz Viktor Klang has updated the pull request incrementally with one additional commit since the last revision: Using apiNote and rewording from method to operation - Changes: - all: https://git.openjdk.org/jdk/pull/13890/files - new: