On Mon, 14 Nov 2022 21:26:08 GMT, Lance Andersen wrote:
>> Please review the following PR which updates several of the ZipInputStream
>> methods whose javadoc is inherited to clarify the methods are acting on
>> the current ZIP Entry.
>>
>> There are no changes in behavior. The main descrip
On Mon, 14 Nov 2022 21:26:08 GMT, Lance Andersen wrote:
>> Please review the following PR which updates several of the ZipInputStream
>> methods whose javadoc is inherited to clarify the methods are acting on
>> the current ZIP Entry.
>>
>> There are no changes in behavior. The main descrip
On Mon, 14 Nov 2022 21:00:16 GMT, Brian Burkhalter wrote:
> Nitpick: should the `InputStream` import precede that of `IOException`?
Gonna leave this as is as IntelliJ keeps changing it and not worth fighting
> src/java.base/share/classes/java/util/zip/ZipInputStream.java line 178:
>
>> 176:
> Please review the following PR which updates several of the ZipInputStream
> methods whose javadoc is inherited to clarify the methods are acting on the
> current ZIP Entry.
>
> There are no changes in behavior. The main description for the method's
> javadoc that has been copied has been
On Mon, 14 Nov 2022 20:03:24 GMT, Lance Andersen wrote:
>> Please review the following PR which updates several of the ZipInputStream
>> methods whose javadoc is inherited to clarify the methods are acting on
>> the current ZIP Entry.
>>
>> There are no changes in behavior. The main descrip
> Please review the following PR which updates several of the ZipInputStream
> methods whose javadoc is inherited to clarify the methods are acting on the
> current ZIP Entry.
>
> There are no changes in behavior. The main description for the method's
> javadoc that has been copied has been
On Mon, 14 Nov 2022 19:48:43 GMT, Alan Bateman wrote:
> The updated wording looks okay. One small thing is that I think it would be a
> bit better if the word "always" were dropped.
Removed always and just pushed another commit with that change. Thank you for
the feedback
-
PR:
On Mon, 14 Nov 2022 18:16:50 GMT, Lance Andersen wrote:
>> Please review the following PR which updates several of the ZipInputStream
>> methods whose javadoc is inherited to clarify the methods are acting on
>> the current ZIP Entry.
>>
>> There are no changes in behavior. The main descrip
On Mon, 14 Nov 2022 11:08:25 GMT, Lance Andersen wrote:
>> src/java.base/share/classes/java/util/zip/ZipInputStream.java line 179:
>>
>>> 177: * {@link #closeEntry()} has been called, otherwise always return
>>> 1.
>>> 178: * I think it will need to say that input stream for the curre
> Please review the following PR which updates several of the ZipInputStream
> methods whose javadoc is inherited to clarify the methods are acting on the
> current ZIP Entry.
>
> There are no changes in behavior. The main description for the method's
> javadoc that has been copied has been
On Mon, 14 Nov 2022 07:17:01 GMT, Alan Bateman wrote:
> A comment from the PR has been pasted here :-)
> Ignoring that, the updated description for the "available" method looks okay
> but might be clearer to say that closeEntry has been called on the current
> entry.
whoops, fixed :-)
---
> Please review the following PR which updates several of the ZipInputStream
> methods whose javadoc is inherited to clarify the methods are acting on the
> current ZIP Entry.
>
> There are no changes in behavior. The main description for the method's
> javadoc that has been copied has been
On Sun, 13 Nov 2022 21:42:38 GMT, Lance Andersen wrote:
>> Please review the following PR which updates several of the ZipInputStream
>> methods whose javadoc is inherited to clarify the methods are acting on
>> the current ZIP Entry.
>>
>> There are no changes in behavior. The main descrip
On Sat, 12 Nov 2022 12:27:30 GMT, Alan Bateman wrote:
> I think it will need to say that input stream for the current ZIP entry has
> been read to end of stream, or the ZIP entry has been closed with closeEntry.
> That will cover the two cases where it returns 0.
Thank you Alan. I have revise
> Please review the following PR which updates several of the ZipInputStream
> methods whose javadoc is inherited to clarify the methods are acting on the
> current ZIP Entry.
>
> There are no changes in behavior. The main description for the method's
> javadoc that has been copied has been
On Fri, 11 Nov 2022 18:56:36 GMT, Lance Andersen wrote:
>> Please review the following PR which updates several of the ZipInputStream
>> methods whose javadoc is inherited to clarify the methods are acting on
>> the current ZIP Entry.
>>
>> There are no changes in behavior. The main descrip
On Fri, 11 Nov 2022 18:51:49 GMT, Lance Andersen wrote:
> Thanks for the suggestion. I made another pass to make the phrasing more
> consistent
Good, I think it looks much better now except for the "available" method which
doesn't fully specify the cases for when it returns 0.
-
On Fri, 11 Nov 2022 17:46:08 GMT, Alan Bateman wrote:
> I think it would be useful to generate the javadoc and see if there are
> terminology or wording differences between the existing and new descriptions
> being copied down from input stream.
>
> For example, the no-arg read is "Reads a byt
> Please review the following PR which updates several of the ZipInputStream
> methods whose javadoc is inherited to clarify the methods are acting on the
> current ZIP Entry.
>
> There are no changes in behavior. The main description for the method's
> javadoc that has been copied has been
On Fri, 11 Nov 2022 17:16:38 GMT, Lance Andersen wrote:
>> Please review the following PR which updates several of the ZipInputStream
>> methods whose javadoc is inherited to clarify the methods are acting on
>> the current ZIP Entry.
>>
>> There are no changes in behavior. The main descrip
On Fri, 11 Nov 2022 12:22:32 GMT, Alan Bateman wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Addressed latest set of input on the javadoc
>
> src/java.base/share/classes/java/util/zip/ZipInputStream.java line 2
On Fri, 4 Nov 2022 18:13:23 GMT, Lance Andersen wrote:
> Please review the following PR which updates several of the ZipInputStream
> methods whose javadoc is inherited to clarify the methods are acting on the
> current ZIP Entry.
>
> There are no changes in behavior. The main description f
> Please review the following PR which updates several of the ZipInputStream
> methods whose javadoc is inherited to clarify the methods are acting on the
> current ZIP Entry.
>
> There are no changes in behavior. The main description for the method's
> javadoc that has been copied has been
On Fri, 4 Nov 2022 18:13:23 GMT, Lance Andersen wrote:
> Please review the following PR which updates several of the ZipInputStream
> methods whose javadoc is inherited to clarify the methods are acting on the
> current ZIP Entry.
>
> There are no changes in behavior. The main description f
On Mon, 7 Nov 2022 16:05:28 GMT, Lance Andersen wrote:
> The javadoc for the checked exceptions will be inherited
Thank you Lance, I wasn't aware of that.
-
PR: https://git.openjdk.org/jdk/pull/10995
On Mon, 7 Nov 2022 10:08:16 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/zip/ZipInputStream.java line 210:
>>
>>> 208: * Reads all remaining bytes from the input stream for the current
>>> ZIP entry.
>>> 209: * This method blocks until all remaining bytes have bee
On Mon, 7 Nov 2022 09:58:03 GMT, Jaikiran Pai wrote:
>> Please review the following PR which updates several of the ZipInputStream
>> methods whose javadoc is inherited to clarify the methods are acting on
>> the current ZIP Entry.
>>
>> There are no changes in behavior. The main descriptio
On Mon, 7 Nov 2022 09:55:52 GMT, Jaikiran Pai wrote:
>> Please review the following PR which updates several of the ZipInputStream
>> methods whose javadoc is inherited to clarify the methods are acting on
>> the current ZIP Entry.
>>
>> There are no changes in behavior. The main descriptio
On Fri, 4 Nov 2022 18:13:23 GMT, Lance Andersen wrote:
> Please review the following PR which updates several of the ZipInputStream
> methods whose javadoc is inherited to clarify the methods are acting on the
> current ZIP Entry.
>
> There are no changes in behavior. The main description f
Please review the following PR which updates several of the ZipInputStream
methods whose javadoc is inherited to clarify the methods are acting on the
current ZIP Entry.
There are no changes in behavior. The main description for the method's
javadoc that has been copied has been clarified an
30 matches
Mail list logo
