Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v14]

2024-01-29 Thread Jim Laskey
> Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage, Jim Laskey has updated the pull request

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v13]

2024-01-29 Thread ExE Boss
On Fri, 26 Jan 2024 17:36:52 GMT, Jim Laskey wrote: >> Currently String::translateEscapes does not support unicode escapes, >> reported as a IllegalArgumentException("Invalid escape sequence: ..."). >> String::translateEscapes should translate unicode escape sequences to >> provide full

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v13]

2024-01-29 Thread Jim Laskey
On Fri, 26 Jan 2024 17:36:52 GMT, Jim Laskey wrote: >> Currently String::translateEscapes does not support unicode escapes, >> reported as a IllegalArgumentException("Invalid escape sequence: ..."). >> String::translateEscapes should translate unicode escape sequences to >> provide full

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v13]

2024-01-29 Thread Naoto Sato
On Fri, 26 Jan 2024 17:36:52 GMT, Jim Laskey wrote: >> Currently String::translateEscapes does not support unicode escapes, >> reported as a IllegalArgumentException("Invalid escape sequence: ..."). >> String::translateEscapes should translate unicode escape sequences to >> provide full

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v13]

2024-01-29 Thread Roger Riggs
On Fri, 26 Jan 2024 17:36:52 GMT, Jim Laskey wrote: >> Currently String::translateEscapes does not support unicode escapes, >> reported as a IllegalArgumentException("Invalid escape sequence: ..."). >> String::translateEscapes should translate unicode escape sequences to >> provide full

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v12]

2024-01-26 Thread Jim Laskey
On Fri, 26 Jan 2024 16:54:14 GMT, Roger Riggs wrote: >> Jim Laskey has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v13]

2024-01-26 Thread Jim Laskey
> Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage, Jim Laskey has updated the pull request

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v12]

2024-01-26 Thread Roger Riggs
On Fri, 26 Jan 2024 15:06:50 GMT, Jim Laskey wrote: >> Currently String::translateEscapes does not support unicode escapes, >> reported as a IllegalArgumentException("Invalid escape sequence: ..."). >> String::translateEscapes should translate unicode escape sequences to >> provide full

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v12]

2024-01-26 Thread Jim Laskey
> Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage, Jim Laskey has updated the pull request with a new

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v11]

2024-01-26 Thread Jim Laskey
> Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage, Jim Laskey has updated the pull request

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v10]

2024-01-26 Thread Jim Laskey
> Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage, Jim Laskey has updated the pull request

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v7]

2024-01-26 Thread Jim Laskey
On Fri, 19 Jan 2024 18:28:22 GMT, Roger Riggs wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update Copyright > > test/jdk/java/lang/String/TranslateEscapes.java line 113: > >> 111: } >> 112: >> 113:

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v8]

2024-01-26 Thread Jim Laskey
On Tue, 23 Jan 2024 21:41:54 GMT, Naoto Sato wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Requested changes > > src/java.base/share/classes/java/lang/String.java line 4229: > >> 4227: * {@code

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v9]

2024-01-26 Thread Jim Laskey
On Fri, 26 Jan 2024 08:38:32 GMT, Alan Bateman wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update String.java > > src/java.base/share/classes/java/lang/String.java line 4238: > >> 4236: * @return String

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v7]

2024-01-26 Thread Jim Laskey
On Fri, 19 Jan 2024 18:27:24 GMT, Roger Riggs wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update Copyright > > test/jdk/java/lang/String/TranslateEscapes.java line 127: > >> 125: } catch

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v6]

2024-01-26 Thread Jim Laskey
On Fri, 19 Jan 2024 17:39:57 GMT, Raffaello Giulietti wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright year of test > > test/jdk/java/lang/String/TranslateEscapes.java line 2: > >> 1: /* >> 2: *

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v9]

2024-01-26 Thread Alan Bateman
On Wed, 24 Jan 2024 13:23:49 GMT, Jim Laskey wrote: >> Currently String::translateEscapes does not support unicode escapes, >> reported as a IllegalArgumentException("Invalid escape sequence: ..."). >> String::translateEscapes should translate unicode escape sequences to >> provide full

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v9]

2024-01-24 Thread Jim Laskey
> Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage, Jim Laskey has updated the pull request

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v8]

2024-01-23 Thread Naoto Sato
On Tue, 23 Jan 2024 18:53:39 GMT, Jim Laskey wrote: >> Currently String::translateEscapes does not support unicode escapes, >> reported as a IllegalArgumentException("Invalid escape sequence: ..."). >> String::translateEscapes should translate unicode escape sequences to >> provide full

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v8]

2024-01-23 Thread Jim Laskey
> Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage, Jim Laskey has updated the pull request

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v7]

2024-01-19 Thread Roger Riggs
On Fri, 19 Jan 2024 18:23:40 GMT, Jim Laskey wrote: >> Currently String::translateEscapes does not support unicode escapes, >> reported as a IllegalArgumentException("Invalid escape sequence: ..."). >> String::translateEscapes should translate unicode escape sequences to >> provide full

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v7]

2024-01-19 Thread Jim Laskey
> Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage, Jim Laskey has updated the pull request

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v6]

2024-01-19 Thread Raffaello Giulietti
On Fri, 19 Jan 2024 14:14:26 GMT, Jim Laskey wrote: >> Currently String::translateEscapes does not support unicode escapes, >> reported as a IllegalArgumentException("Invalid escape sequence: ..."). >> String::translateEscapes should translate unicode escape sequences to >> provide full

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v6]

2024-01-19 Thread Jim Laskey
> Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage, Jim Laskey has updated the pull request

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v6]

2024-01-19 Thread Raffaello Giulietti
On Fri, 19 Jan 2024 14:10:48 GMT, Jim Laskey wrote: >> Currently String::translateEscapes does not support unicode escapes, >> reported as a IllegalArgumentException("Invalid escape sequence: ..."). >> String::translateEscapes should translate unicode escape sequences to >> provide full

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v5]

2024-01-19 Thread Jim Laskey
> Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage, Jim Laskey has updated the pull request

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v4]

2024-01-19 Thread Raffaello Giulietti
On Fri, 19 Jan 2024 12:26:51 GMT, Jim Laskey wrote: >> Currently String::translateEscapes does not support unicode escapes, >> reported as a IllegalArgumentException("Invalid escape sequence: ..."). >> String::translateEscapes should translate unicode escape sequences to >> provide full

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v4]

2024-01-19 Thread Jim Laskey
> Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage, Jim Laskey has updated the pull request

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v3]

2024-01-19 Thread Jim Laskey
> Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage, Jim Laskey has updated the pull request

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v2]

2024-01-18 Thread Jim Laskey
> Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage, Jim Laskey has updated the pull request

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes

2024-01-18 Thread Jim Laskey
On Thu, 18 Jan 2024 19:25:28 GMT, Raffaello Giulietti wrote: >> Currently String::translateEscapes does not support unicode escapes, >> reported as a IllegalArgumentException("Invalid escape sequence: ..."). >> String::translateEscapes should translate unicode escape sequences to >> provide

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes

2024-01-18 Thread Raffaello Giulietti
On Thu, 18 Jan 2024 18:50:56 GMT, Jim Laskey wrote: > Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage,

RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes

2024-01-18 Thread Jim Laskey
Currently String::translateEscapes does not support unicode escapes, reported as a IllegalArgumentException("Invalid escape sequence: ..."). String::translateEscapes should translate unicode escape sequences to provide full coverage, - Commit messages: - Unicode escape sequences