Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v3]

2022-08-09 Thread ScientificWare
On Tue, 9 Aug 2022 08:38:26 GMT, Jaikiran Pai wrote: >> ScientificWare has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains ten additional >>

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v3]

2022-08-09 Thread Jaikiran Pai
On Fri, 5 Aug 2022 08:59:00 GMT, ScientificWare wrote: >> This is tracked in JBS as >> >> [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) and duplicated by >> [JDK-8290070](https://bugs.openjdk.org/browse/JDK-8290070) >> >> Unused imports in DTDBuider.java. >> >>> **Remove unused

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v2]

2022-08-09 Thread ScientificWare
On Tue, 9 Aug 2022 02:37:21 GMT, Jaikiran Pai wrote: >> Hello @jaikiran, the copyright years were updated by a previous commit. > > @scientificware, please issue the integrate command when you are ready and I > can sponsor this for you. In the meantime, I'll run some tests to be sure > that

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v2]

2022-08-08 Thread Jaikiran Pai
On Fri, 5 Aug 2022 09:02:44 GMT, ScientificWare wrote: >> Hello @scientificware, what you propose here, I think looks fine. >> Additionally can you also update the copyright years on this file from >> `Copyright (c) 1998, 2020,` to `Copyright (c) 1998, 2022,`? >> >> I see that the changed

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v3]

2022-08-08 Thread Jaikiran Pai
On Fri, 5 Aug 2022 08:59:00 GMT, ScientificWare wrote: >> This is tracked in JBS as >> >> [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) and duplicated by >> [JDK-8290070](https://bugs.openjdk.org/browse/JDK-8290070) >> >> Unused imports in DTDBuider.java. >> >>> **Remove unused

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v3]

2022-08-08 Thread Magnus Ihse Bursie
On Fri, 5 Aug 2022 09:55:58 GMT, Jaikiran Pai wrote: >> ScientificWare has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains ten additional >>

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v2]

2022-08-05 Thread ScientificWare
On Fri, 5 Aug 2022 07:56:40 GMT, Jaikiran Pai wrote: >> Just waiting to be reviewed. > > Hello @scientificware, what you propose here, I think looks fine. > Additionally can you also update the copyright years on this file from > `Copyright (c) 1998, 2020,` to `Copyright (c) 1998, 2022,`? > >

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v3]

2022-08-05 Thread ScientificWare
> This is tracked in JBS as > > [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) and duplicated by > [JDK-8290070](https://bugs.openjdk.org/browse/JDK-8290070) > > Unused imports in DTDBuider.java. > >> **Remove unused imports from DTDBuilder.java** > > Some imports are no more

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v2]

2022-08-05 Thread Jaikiran Pai
On Thu, 4 Aug 2022 06:25:27 GMT, ScientificWare wrote: >> ScientificWare has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >>

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v2]

2022-08-04 Thread ScientificWare
On Wed, 6 Jul 2022 23:56:33 GMT, ScientificWare wrote: >> This is tracked in JBS as >> >> [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) and duplicated by >> [JDK-8290070](https://bugs.openjdk.org/browse/JDK-8290070) >> >> Unused imports in DTDBuider.java. >> >>> **Remove unused

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java [v2]

2022-07-07 Thread ScientificWare
> This is tracked in JBS as > > [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) > >> **Remove unused imports from DTDBuilder.java** > > Some imports are no more used. > > - java.io.FileNotFoundException; > - java.io.BufferedInputStream; > - java.io.OutputStream; > -

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java

2022-07-06 Thread Julian Waters
On Mon, 4 Jul 2022 07:04:40 GMT, ScientificWare wrote: > This is tracked in JBS as > > [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) > >> **Remove unused imports from DTDBuilder.java** > Some imports are no more used. > > - java.io.FileNotFoundException; > -

RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java

2022-07-06 Thread ScientificWare
This is tracked in JBS as [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) > **Remove unused imports from DTDBuilder.java** Some imports are no more used. - java.io.FileNotFoundException; - java.io.BufferedInputStream; - java.io.OutputStream; - java.util.BitSet; -

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java

2022-07-06 Thread ScientificWare
On Tue, 5 Jul 2022 11:34:05 GMT, Julian Waters wrote: >> Alright, was asking since I can help create one for you, but it seems that >> others already have it covered > >> @TheShermanTanker , thank you for asking and helping. >> >> > it seems that others already have it covered >> >> In fact,

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java

2022-07-05 Thread Julian Waters
On Tue, 5 Jul 2022 03:40:51 GMT, Julian Waters wrote: >> This is tracked in JBS as >> >> [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) >> >>> **Remove unused imports from DTDBuilder.java** >> Some imports are no more used. >> >> - java.io.FileNotFoundException; >> -

Re: RFR: JDK-8289741 : Remove unused imports from DTDBuilder.java

2022-07-05 Thread ScientificWare
On Tue, 5 Jul 2022 01:53:33 GMT, Julian Waters wrote: >> This is tracked in JBS as >> >> [JDK-8289741](https://bugs.openjdk.org/browse/JDK-8289741) >> >>> **Remove unused imports from DTDBuilder.java** >> Some imports are no more used. >> >> - java.io.FileNotFoundException; >> -