Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos [v2]

2022-10-11 Thread Markus KARG
On Tue, 11 Oct 2022 15:40:36 GMT, Brian Burkhalter wrote: >> Markus KARG has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Modified to < 0 as proposed by Alan Batement > > Marked as reviewed by bpb (Reviewer). @bplb Kindly requesting to

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos [v2]

2022-10-11 Thread Brian Burkhalter
On Tue, 4 Oct 2022 15:53:04 GMT, Alan Bateman wrote: >> This is true, but if a broken subclass sets markpos to less than -1 then >> lots of code lines will work incorrectly -- including `transferTo` which was >> the starting point of your change proposal. So do you really only want undo >>

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos [v2]

2022-10-11 Thread Brian Burkhalter
On Sun, 9 Oct 2022 14:08:40 GMT, Markus KARG wrote: >> Fixes JDK-8294702 > > Markus KARG has updated the pull request incrementally with one additional > commit since the last revision: > > Modified to < 0 as proposed by Alan Batement Marked as reviewed by bpb (Reviewer). -

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos [v2]

2022-10-11 Thread Markus KARG
On Tue, 4 Oct 2022 15:53:04 GMT, Alan Bateman wrote: >> This is true, but if a broken subclass sets markpos to less than -1 then >> lots of code lines will work incorrectly -- including `transferTo` which was >> the starting point of your change proposal. So do you really only want undo >>

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos [v2]

2022-10-10 Thread Brian Burkhalter
On Sun, 9 Oct 2022 14:04:45 GMT, Markus KARG wrote: >>> This is true, but if a broken subclass sets markpos to less than -1 then >>> lots of code lines will work incorrectly -- including `transferTo` which >>> was the starting point of your change proposal. So do you really only want >>> undo

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos [v2]

2022-10-09 Thread Markus KARG
On Tue, 4 Oct 2022 15:53:04 GMT, Alan Bateman wrote: >> This is true, but if a broken subclass sets markpos to less than -1 then >> lots of code lines will work incorrectly -- including `transferTo` which was >> the starting point of your change proposal. So do you really only want undo >>

Re: RFR: JDK-8294702 - BufferedInputStream uses undefined value range for markpos [v2]

2022-10-09 Thread Markus KARG
> Fixes JDK-8294702 Markus KARG has updated the pull request incrementally with one additional commit since the last revision: Modified to < 0 as proposed by Alan Batement - Changes: - all: https://git.openjdk.org/jdk/pull/10528/files - new: