Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v4]

2022-10-12 Thread Naoto Sato
On Wed, 12 Oct 2022 18:31:16 GMT, Bill Huang wrote: >> The jarsigner and keytool are localized into English, German, Japanese and >> Simplified Chinese. This task is to modify the existing i18n tests to >> validate i18n compliance in these tools. >> >> In addition, this task also contains

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v4]

2022-10-12 Thread Bill Huang
> The jarsigner and keytool are localized into English, German, Japanese and > Simplified Chinese. This task is to modify the existing i18n tests to > validate i18n compliance in these tools. > > In addition, this task also contains changes for manual test enhancement and > simplification

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v3]

2022-10-12 Thread Bill Huang
> The jarsigner and keytool are localized into English, German, Japanese and > Simplified Chinese. This task is to modify the existing i18n tests to > validate i18n compliance in these tools. > > In addition, this task also contains changes for manual test enhancement and > simplification

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v2]

2022-10-12 Thread Naoto Sato
On Mon, 10 Oct 2022 23:23:00 GMT, Bill Huang wrote: >> The jarsigner and keytool are localized into English, German, Japanese and >> Simplified Chinese. This task is to modify the existing i18n tests to >> validate i18n compliance in these tools. >> >> In addition, this task also contains

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v2]

2022-10-11 Thread Bill Huang
On Tue, 11 Oct 2022 15:17:13 GMT, Weijun Wang wrote: >> Bill Huang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Implemented review comments. > > I have a question, why must this test be manual? Can't we compare the > localized

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v2]

2022-10-11 Thread Naoto Sato
On Tue, 11 Oct 2022 15:17:13 GMT, Weijun Wang wrote: > I have a question, why must this test be manual? Can't we compare the > localized texts? Thought about that, but it could be a nuisance if we compared word-to-word translations, considering the situation if an engineer made some changes

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v2]

2022-10-11 Thread Bill Huang
On Tue, 11 Oct 2022 17:03:47 GMT, Naoto Sato wrote: > I have a question, why must this test be manual? Can't we compare the > localized texts? @wangweij Good question. We can definitely compare the localized texts at least some keywords. The fact that automation is one of the goals of this

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v2]

2022-10-11 Thread Weijun Wang
On Mon, 10 Oct 2022 23:23:00 GMT, Bill Huang wrote: >> The jarsigner and keytool are localized into English, German, Japanese and >> Simplified Chinese. This task is to modify the existing i18n tests to >> validate i18n compliance in these tools. >> >> In addition, this task also contains

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance [v2]

2022-10-10 Thread Bill Huang
> The jarsigner and keytool are localized into English, German, Japanese and > Simplified Chinese. This task is to modify the existing i18n tests to > validate i18n compliance in these tools. > > In addition, this task also contains changes for manual test enhancement and > simplification

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance

2022-10-10 Thread Bill Huang
On Mon, 10 Oct 2022 19:47:37 GMT, Naoto Sato wrote: >> The jarsigner and keytool are localized into English, German, Japanese and >> Simplified Chinese. This task is to modify the existing i18n tests to >> validate i18n compliance in these tools. >> >> In addition, this task also contains

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance

2022-10-10 Thread Bill Huang
On Mon, 10 Oct 2022 19:45:31 GMT, Naoto Sato wrote: >> The jarsigner and keytool are localized into English, German, Japanese and >> Simplified Chinese. This task is to modify the existing i18n tests to >> validate i18n compliance in these tools. >> >> In addition, this task also contains

Re: RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance

2022-10-10 Thread Naoto Sato
On Mon, 10 Oct 2022 18:18:55 GMT, Bill Huang wrote: > The jarsigner and keytool are localized into English, German, Japanese and > Simplified Chinese. This task is to modify the existing i18n tests to > validate i18n compliance in these tools. > > In addition, this task also contains changes

RFR: JDK-8294994: Update Jarsigner and Keytool i18n tests to validate i18n compliance

2022-10-10 Thread Bill Huang
The jarsigner and keytool are localized into English, German, Japanese and Simplified Chinese. This task is to modify the existing i18n tests to validate i18n compliance in these tools. In addition, this task also contains changes for manual test enhancement and simplification which