Re: [jdk20] RFR: JDK-8298277: Replace "session" with "scope" for FFM access

2022-12-14 Thread Maurizio Cimadamore
On Wed, 14 Dec 2022 09:30:21 GMT, Per Minborg wrote: > This PR proposes changing variable names from `session` to `scope`. The > proposed changes are only for the FFM API and not other parts like the Vector > API and test classes. Looks good! - Marked as reviewed by mcimadamore

[jdk20] RFR: JDK-8298277: Replace "session" with "scope" for FFM access

2022-12-14 Thread Per Minborg
This PR proposes changing variable names from `session` to `scope`. The proposed changes are only for the FFM API and not other parts like the Vector API and test classes. - Commit messages: - Replace session with scope for FFM access Changes:

Re: RFR: JDK-8298277: Replace "session" with "scope" for FFM access [v2]

2022-12-08 Thread Maurizio Cimadamore
On Thu, 8 Dec 2022 15:57:23 GMT, Per Minborg wrote: >> This PR proposes changing variable names and text from "session" to "scope". >> The proposed changes are only for the FFM API and not other parts like the >> Vector API and test classes. > > Per Minborg has updated the pull request

Re: RFR: JDK-8298277: Replace "session" with "scope" for FFM access [v2]

2022-12-08 Thread Per Minborg
> This PR proposes changing variable names and text from "session" to "scope". > The proposed changes are only for the FFM API and not other parts like the > Vector API and test classes. Per Minborg has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: JDK-8298277: Replace "session" with "scope" for FFM access

2022-12-08 Thread Per Minborg
On Thu, 8 Dec 2022 14:36:52 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/jdk/internal/foreign/abi/Binding.java line 255: >> >>> 253: * the context's allocator is accessed. >>> 254: */ >>> 255: public static Context ofScope() { >> >> I think

Re: RFR: JDK-8298277: Replace "session" with "scope" for FFM access

2022-12-08 Thread Maurizio Cimadamore
On Thu, 8 Dec 2022 14:33:01 GMT, Maurizio Cimadamore wrote: >> This PR proposes changing variable names and text from "session" to "scope". >> The proposed changes are only for the FFM API and not other parts like the >> Vector API and test classes. > >

Re: RFR: JDK-8298277: Replace "session" with "scope" for FFM access

2022-12-08 Thread Maurizio Cimadamore
On Thu, 8 Dec 2022 14:11:29 GMT, Per Minborg wrote: > This PR proposes changing variable names and text from "session" to "scope". > The proposed changes are only for the FFM API and not other parts like the > Vector API and test classes.

RFR: JDK-8298277: Replace "session" with "scope" for FFM access

2022-12-08 Thread Per Minborg
This PR proposes changing variable names and text from "session" to "scope". The proposed changes are only for the FFM API and not other parts like the Vector API and test classes. - Commit messages: - Rename session to scope Changes: https://git.openjdk.org/jdk/pull/11593/files