Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v3]

2023-02-24 Thread Joe Darcy
> The wheel of FDLIBM porting turns a notch and sqrt comes into play. > > While the sqrt operation usually has a hardware implementation that is > intrinsified, for completeness a software implementation should be available > as well. Joe Darcy has updated the pull request incrementally with on

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v3]

2023-02-24 Thread Brian Burkhalter
On Fri, 24 Feb 2023 18:40:38 GMT, Joe Darcy wrote: >> The wheel of FDLIBM porting turns a notch and sqrt comes into play. >> >> While the sqrt operation usually has a hardware implementation that is >> intrinsified, for completeness a software implementation should be available >> as well. > >

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v3]

2023-02-25 Thread Andrey Turbanov
On Fri, 24 Feb 2023 18:40:38 GMT, Joe Darcy wrote: >> The wheel of FDLIBM porting turns a notch and sqrt comes into play. >> >> While the sqrt operation usually has a hardware implementation that is >> intrinsified, for completeness a software implementation should be available >> as well. > >

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v3]

2023-02-25 Thread Joe Darcy
On Thu, 23 Feb 2023 23:30:46 GMT, Joe Darcy wrote: > I'll revert commenting out the intrinsic annotation before pushing. Turns out some VM updates are needed to preserve the intrinsic if this method declaration is changed; I'll be contacting the HotSpot team for assistance. - PR:

Re: RFR: JDK-8302040: Port fdlibm sqrt to Java [v3]

2023-02-25 Thread Joe Darcy
On Sat, 25 Feb 2023 18:06:46 GMT, Andrey Turbanov wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add one one unsigned shift comment. > > src/java.base/share/classes/java/lang/FdLibm.java line 639: > >> 637: