On Sun, 5 Mar 2023 17:10:08 GMT, Joe Darcy wrote:
> PS Successful Mach 5 job of default builds and tier 1 tests with this make
> line present.
PPS And for extra measure as suggested by David Holmes, a tier 1 through 5
build job was also successful.
-
PR:
On Sun, 5 Mar 2023 06:19:06 GMT, Joe Darcy wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
>> thought I'd get out for the review the next phase of the FDLIBM port:
>> removing the FDLIBM C sources from the repo.
>>
>> A repo with the changes for
On Sun, 5 Mar 2023 06:19:06 GMT, Joe Darcy wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
>> thought I'd get out for the review the next phase of the FDLIBM port:
>> removing the FDLIBM C sources from the repo.
>>
>> A repo with the changes for
On Sun, 5 Mar 2023 06:19:06 GMT, Joe Darcy wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
>> thought I'd get out for the review the next phase of the FDLIBM port:
>> removing the FDLIBM C sources from the repo.
>>
>> A repo with the changes for
On Thu, 2 Mar 2023 18:27:09 GMT, Joe Darcy wrote:
>> make/autoconf/buildjdk-spec.gmk.in line 85:
>>
>>> 83: JVM_LIBS := @OPENJDK_BUILD_JVM_LIBS@
>>> 84:
>>> 85: FDLIBM_CFLAGS := @OPENJDK_BUILD_FDLIBM_CFLAGS@
>>
>> If the hotspot build still needs `FDLIBM_CFLAGS`, then this line needs to
>>
> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
> thought I'd get out for the review the next phase of the FDLIBM port:
> removing the FDLIBM C sources from the repo.
>
> A repo with the changes for JDK-8302027 and this PR successful build on the
> default set of
On Fri, 3 Mar 2023 01:02:40 GMT, Vladimir Kozlov wrote:
> Hotspot changes are okay but I'm a bit confused about what the hotspot code
> will now be used for?
I'm not 100% positive if the current __kernel_rem_pio2 code would be in use.
IIRC, back when we used the fsin/fcos instructions to
On Fri, 3 Mar 2023 00:38:18 GMT, David Holmes wrote:
> Actually this is really my lack of understanding about the current code: why
> do we intrinsify `Math` but not `StrictMath`?
In brief, the Math methods are allowed implementation flexibility in terms of
their algorithm but the StrictMath
On Fri, 3 Mar 2023 00:31:12 GMT, David Holmes wrote:
> Hotspot changes are okay but I'm a bit confused about what the hotspot code
> will now be used for?
`SharedRuntime::*` runtime math functions are used on platforms where there are
no HW instructions or intrinsics (Zero VM). JIT compiled
On Thu, 2 Mar 2023 19:55:39 GMT, Joe Darcy wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
>> thought I'd get out for the review the next phase of the FDLIBM port:
>> removing the FDLIBM C sources from the repo.
>>
>> A repo with the changes for
On Thu, 2 Mar 2023 19:55:39 GMT, Joe Darcy wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
>> thought I'd get out for the review the next phase of the FDLIBM port:
>> removing the FDLIBM C sources from the repo.
>>
>> A repo with the changes for
On Thu, 2 Mar 2023 19:55:39 GMT, Joe Darcy wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
>> thought I'd get out for the review the next phase of the FDLIBM port:
>> removing the FDLIBM C sources from the repo.
>>
>> A repo with the changes for
> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
> thought I'd get out for the review the next phase of the FDLIBM port:
> removing the FDLIBM C sources from the repo.
>
> A repo with the changes for JDK-8302027 and this PR successful build on the
> default set of
On Thu, 2 Mar 2023 19:19:20 GMT, Brian Burkhalter wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback and add description of transliteration process.
>
>
On Thu, 2 Mar 2023 18:31:54 GMT, Joe Darcy wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
>> thought I'd get out for the review the next phase of the FDLIBM port:
>> removing the FDLIBM C sources from the repo.
>>
>> A repo with the changes for
On Thu, 2 Mar 2023 18:31:54 GMT, Joe Darcy wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
>> thought I'd get out for the review the next phase of the FDLIBM port:
>> removing the FDLIBM C sources from the repo.
>>
>> A repo with the changes for
On Thu, 2 Mar 2023 07:12:01 GMT, Alan Bateman wrote:
> This is a great milestone to get to! Does the comment at the top of
> sharedRuntimeTrig.cpp need updating?
Updated several of the comments in the HotSpot sources and added a description
of the transliteration process to StrictMath.
> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
> thought I'd get out for the review the next phase of the FDLIBM port:
> removing the FDLIBM C sources from the repo.
>
> A repo with the changes for JDK-8302027 and this PR successful build on the
> default set of
On Thu, 2 Mar 2023 14:05:55 GMT, Erik Joelsson wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback and add description of transliteration process.
>
> make/autoconf/buildjdk-spec.gmk.in line
On Thu, 2 Mar 2023 05:54:52 GMT, Joe Darcy wrote:
> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
> thought I'd get out for the review the next phase of the FDLIBM port:
> removing the FDLIBM C sources from the repo.
>
> A repo with the changes for JDK-8302027
On Thu, 2 Mar 2023 05:54:52 GMT, Joe Darcy wrote:
> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
> thought I'd get out for the review the next phase of the FDLIBM port:
> removing the FDLIBM C sources from the repo.
>
> A repo with the changes for JDK-8302027
While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
thought I'd get out for the review the next phase of the FDLIBM port: removing
the FDLIBM C sources from the repo.
A repo with the changes for JDK-8302027 and this PR successful build on the
default set of platform
22 matches
Mail list logo
