Re: RFR: JDK-8303794: IEEEremainder problems are causing test failures after JDK-8302801

2023-03-08 Thread Raffaello Giulietti
On Wed, 8 Mar 2023 01:30:58 GMT, Joe Darcy wrote: > Quick port of IEEEremainder; sorry for missing this earlier. Will add > targeted tests in a follow-up fix. src/java.base/share/classes/java/lang/FdLibm.java line 3367: > 3365: /* purge off exception values */ > 3366: i

Re: RFR: JDK-8303794: IEEEremainder problems are causing test failures after JDK-8302801

2023-03-08 Thread Raffaello Giulietti
On Wed, 8 Mar 2023 01:30:58 GMT, Joe Darcy wrote: > Quick port of IEEEremainder; sorry for missing this earlier. Will add > targeted tests in a follow-up fix. src/java.base/share/classes/java/lang/FdLibm.java line 3437: > 3435: return Zero[sx>>>31]; // unsigned shift > 3436:

Re: RFR: JDK-8303794: IEEEremainder problems are causing test failures after JDK-8302801

2023-03-07 Thread Brian Burkhalter
On Wed, 8 Mar 2023 01:30:58 GMT, Joe Darcy wrote: > Quick port of IEEEremainder; sorry for missing this earlier. Will add > targeted tests in a follow-up fix. Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.org/jdk/pull/12915

Re: RFR: JDK-8303794: IEEEremainder problems are causing test failures after JDK-8302801

2023-03-07 Thread David Holmes
On Wed, 8 Mar 2023 01:30:58 GMT, Joe Darcy wrote: > Quick port of IEEEremainder; sorry for missing this earlier. Will add > targeted tests in a follow-up fix. I can't attest to the correctness of the algorithm but I assume the necessary testing has been done in that regard. I can attest to thi

RFR: JDK-8303794: IEEEremainder problems are causing test failures after JDK-8302801

2023-03-07 Thread Joe Darcy
Quick port of IEEEremainder; sorry for missing this earlier. Will add targeted tests in a follow-up fix. - Commit messages: - Fixes. - JDK-8303794: IEEEremainder problems are causing test failures after JDK-8302801 Changes: https://git.openjdk.org/jdk/pull/12915/files Webrev: ht