On Fri, 2 Jun 2023 04:48:35 GMT, Joe Darcy wrote:
>> Explain in java.lang.Class how unnamed classes are modeled in core
>> reflection.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update reflective support.
The changes fo
On Mon, 5 Jun 2023 10:17:01 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update reflective support.
>
> src/java.base/share/classes/java/lang/Class.java line 216:
>
>> 214: * {@linkplain #getSim
On Mon, 5 Jun 2023 10:11:17 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update reflective support.
>
> src/java.base/share/classes/java/lang/Class.java line 1881:
>
>> 1879: * @since 21
>>
On Mon, 5 Jun 2023 10:08:59 GMT, Alan Bateman wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update reflective support.
>
> src/java.base/share/classes/java/lang/Class.java line 29:
>
>> 27:
>> 28: import jdk.inter
On Fri, 2 Jun 2023 04:48:35 GMT, Joe Darcy wrote:
>> Explain in java.lang.Class how unnamed classes are modeled in core
>> reflection.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update reflective support.
Will this meth
On Fri, 2 Jun 2023 23:46:57 GMT, Chen Liang wrote:
> Will this accidentally return `true` for classes from other JVM programming
> languages?
That is a potential concern. Future iteration of this work will likely use a
different idiom to determine is-unnamed that would be more robust against f
On Fri, 2 Jun 2023 18:41:57 GMT, Mandy Chung wrote:
>> As mentioned in https://bugs.openjdk.org/browse/JDK-8308916 the expression
>> should be `PreviewFeatures.isEnabled() && isSynthetic() &&
>> isTopLevelClass()` as `PreviewFeatures.isEnabled()` is a private static
>> final test that will ef
On Fri, 2 Jun 2023 18:09:23 GMT, Jim Laskey wrote:
>> Hmm. I think adding at least a check for ACC_FINAL should be fine as it
>> should have near-zero cost on top of the existing predicate once the method
>> get compiled. (In future iterations of the JEP, the idiom to identify
>> isUnnamed wil
On Fri, 2 Jun 2023 17:25:20 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/Class.java line 1884:
>>
>>> 1882: reflective=true)
>>> 1883: public boolean isUnnamedClass() {
>>> 1884: return isSynthetic() && PreviewFeatures.isEnabled() &&
>>> isTopLe
On Fri, 2 Jun 2023 16:44:35 GMT, Mandy Chung wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update reflective support.
>
> src/java.base/share/classes/java/lang/Class.java line 1884:
>
>> 1882: r
On Fri, 2 Jun 2023 04:48:35 GMT, Joe Darcy wrote:
>> Explain in java.lang.Class how unnamed classes are modeled in core
>> reflection.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update reflective support.
src/java.base/
> Explain in java.lang.Class how unnamed classes are modeled in core reflection.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Update reflective support.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/14165/files
12 matches
Mail list logo
