Re: RFR: JDK-8310550: Adjust references to rt.jar [v5]

2023-07-09 Thread Alan Bateman
On Fri, 30 Jun 2023 09:57:04 GMT, Matthias Baesken wrote: > Hi Alan, I adjusted the comment in DriverManager.java . Thanks, the update looks okay. - PR Review Comment: https://git.openjdk.org/jdk/pull/14593#discussion_r1257728322

Re: RFR: JDK-8310550: Adjust references to rt.jar [v5]

2023-07-06 Thread Matthias Baesken
> There are a few references to rt.jar in comments and in the codebase itself. > Some of them might be removed or adjusted. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: Adjust comment - Changes: - all:

Re: RFR: JDK-8310550: Adjust references to rt.jar [v5]

2023-07-06 Thread David Holmes
On Thu, 22 Jun 2023 09:23:05 GMT, Matthias Baesken wrote: >> test/langtools/tools/javap/4798312/JavapShouldLoadClassesFromRTJarTest.java >> line 1: >> >>> 1: /* >> >> The name of this test includes RTJar. It needs to be changed too I think. >> Does this test actually still test something? >