Re: RFR: JDK-8319122: Improve documentation of various Zip-file related APIs [v2]

2024-01-09 Thread Yakov Shafranovich
On Mon, 13 Nov 2023 18:11:12 GMT, Alan Bateman wrote: >> That would probably also involve taking existing documentation such as the >> note about not opening entries with "."/"..", and the POSIX permissions >> mappings? Would it make sense to split the rest of the changes in this PR >> from th

Re: RFR: JDK-8319122: Improve documentation of various Zip-file related APIs [v2]

2024-01-09 Thread Yakov Shafranovich
On Wed, 22 Nov 2023 22:23:18 GMT, Yakov Shafranovich wrote: >> src/java.base/share/classes/java/util/zip/ZipInputStream.java line 77: >> >>> 75: * >>> 76: * Whenever possible, {@linkplain ZipFile} should be used for parsing >>> ZIP >>> 77: * archives since it correctly reads data from the ce

Re: RFR: JDK-8319122: Improve documentation of various Zip-file related APIs [v2]

2024-01-02 Thread Yakov Shafranovich
On Fri, 10 Nov 2023 15:44:19 GMT, Yakov Shafranovich wrote: >> The various Zip/Jar-file related Java APIs have some long-standing >> differences or peculiarities with respect to the ZIP-file specification or >> compared to other implementations which should be documented in the API-doc. >> Thi

Re: RFR: JDK-8319122: Improve documentation of various Zip-file related APIs [v2]

2023-11-22 Thread Yakov Shafranovich
On Tue, 14 Nov 2023 12:21:42 GMT, Alan Bateman wrote: >> Yakov Shafranovich has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fixed more line breaks >> - fixed line breaks > > src/java.base/share/classes/java/util/zip/ZipInputStream.jav

Re: RFR: JDK-8319122: Improve documentation of various Zip-file related APIs [v2]

2023-11-14 Thread Alan Bateman
On Fri, 10 Nov 2023 15:44:19 GMT, Yakov Shafranovich wrote: >> The various Zip/Jar-file related Java APIs have some long-standing >> differences or peculiarities with respect to the ZIP-file specification or >> compared to other implementations which should be documented in the API-doc. >> Thi

Re: RFR: JDK-8319122: Improve documentation of various Zip-file related APIs [v2]

2023-11-13 Thread Alan Bateman
On Mon, 13 Nov 2023 16:00:05 GMT, Yakov Shafranovich wrote: > That would probably also involve taking existing documentation such as the > note about not opening entries with "."/"..", and the POSIX permissions > mappings? Would it make sense to split the rest of the changes in this PR > from

Re: RFR: JDK-8319122: Improve documentation of various Zip-file related APIs [v2]

2023-11-13 Thread Yakov Shafranovich
On Sat, 11 Nov 2023 14:04:11 GMT, Alan Bateman wrote: >> Yakov Shafranovich has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fixed more line breaks >> - fixed line breaks > > src/jdk.zipfs/share/classes/module-info.java line 310: > >>

Re: RFR: JDK-8319122: Improve documentation of various Zip-file related APIs [v2]

2023-11-11 Thread Alan Bateman
On Fri, 10 Nov 2023 15:44:19 GMT, Yakov Shafranovich wrote: >> The various Zip/Jar-file related Java APIs have some long-standing >> differences or peculiarities with respect to the ZIP-file specification or >> compared to other implementations which should be documented in the API-doc. >> Thi

Re: RFR: JDK-8319122: Improve documentation of various Zip-file related APIs [v2]

2023-11-10 Thread Yakov Shafranovich
> The various Zip/Jar-file related Java APIs have some long-standing > differences or peculiarities with respect to the ZIP-file specification or > compared to other implementations which should be documented in the API-doc. > This documents the following: > - Cache of JAR files in JarURLConnect

Re: RFR: JDK-8319122: Improve documentation of various Zip-file related APIs [v2]

2023-11-10 Thread Yakov Shafranovich
On Thu, 9 Nov 2023 20:43:25 GMT, Kevin Driver wrote: >> Yakov Shafranovich has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fixed more line breaks >> - fixed line breaks > > src/jdk.zipfs/share/classes/module-info.java line 303: > >>