Re: RFR: JDK-8319626: Override toString() for ZipFile [v4]

2023-11-28 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982) > which overrides and provides an implementation of `toString()` in > _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_). > > This change is primarily to provide a more informative String representati

Re: RFR: JDK-8319626: Override toString() for ZipFile [v4]

2023-11-28 Thread Bernd
On Wed, 15 Nov 2023 18:30:27 GMT, Justin Lu wrote: >> src/java.base/share/classes/java/util/zip/ZipFile.java line 498: >> >>> 496: */ >>> 497: @Override >>> 498: public String toString() { >> >> I don't think the file name on its own is very helpful as it may not be >> unique or t

Re: RFR: JDK-8319626: Override toString() for ZipFile [v4]

2023-11-30 Thread Jaikiran Pai
On Wed, 29 Nov 2023 01:10:29 GMT, Bernd wrote: >> Hi Alan, >> >> Thanks for taking a look. I updated the toString() value to the one you >> suggested, and also dropped the specific aspects of the specification. >> >> I am not sure if you have a preference one way or another regarding >> prov