Re: RFR: JDK-8319626: Override toString() for ZipFile [v7]

2023-12-12 Thread Jaikiran Pai
On Mon, 11 Dec 2023 05:44:38 GMT, Justin Lu wrote: >> src/java.base/share/classes/java/util/zip/ZipFile.java line 494: >> >>> 492: @Override >>> 493: public String toString() { >>> 494: return res.zsrc.key.file.getName() >> >> Hello Justin, relying on `res.zsrc.key.file` to get

Re: RFR: JDK-8319626: Override toString() for ZipFile [v7]

2023-12-10 Thread Justin Lu
On Fri, 8 Dec 2023 10:18:18 GMT, Jaikiran Pai wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> drop additional specification > > src/java.base/share/classes/java/util/zip/ZipFile.java line 494: > >> 492:

Re: RFR: JDK-8319626: Override toString() for ZipFile [v7]

2023-12-08 Thread Jaikiran Pai
On Fri, 1 Dec 2023 21:32:57 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982) >> which overrides and provides an implementation of `toString()` in >> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_). > > Justin Lu has

Re: RFR: JDK-8319626: Override toString() for ZipFile [v7]

2023-12-01 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982) > which overrides and provides an implementation of `toString()` in > _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_). Justin Lu has updated the pull request incrementally with one additional