Re: RFR: JDK-8319626: Override toString() for ZipFile [v8]

2023-12-10 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982) > which overrides and provides an implementation of `toString()` in > _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_). Justin Lu has updated the pull request with a new target base due to a merge o

Re: RFR: JDK-8319626: Override toString() for ZipFile [v8]

2023-12-12 Thread Jaikiran Pai
On Mon, 11 Dec 2023 05:47:33 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982) >> which overrides and provides an implementation of `toString()` in >> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_). > > Justin Lu has updat

Re: RFR: JDK-8319626: Override toString() for ZipFile [v8]

2023-12-13 Thread Eirik Bjorsnos
On Mon, 11 Dec 2023 05:47:33 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982) >> which overrides and provides an implementation of `toString()` in >> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_). > > Justin Lu has updat

Re: RFR: JDK-8319626: Override toString() for ZipFile [v8]

2023-12-13 Thread Justin Lu
On Wed, 13 Dec 2023 18:35:40 GMT, Eirik Bjorsnos wrote: > I'm seeing the `ZipSourceCache` fail on GHA on `windows-x64`: Hi Eirik, Please let me know if I'm misunderstanding, But this change hasn't been integrated into the master branch yet. Your linked PR does not appear to contain the conten

Re: RFR: JDK-8319626: Override toString() for ZipFile [v8]

2023-12-13 Thread Eirik Bjorsnos
On Wed, 13 Dec 2023 20:53:17 GMT, Justin Lu wrote: > > I'm seeing the `ZipSourceCache` fail on GHA on `windows-x64`: > > Hi Eirik, > > Please let me know if I'm misunderstanding, I claim `TooManyOpenTabsException` :-) Sorry, this comment was for #16115 - PR Comment: https://git.o

Re: RFR: JDK-8319626: Override toString() for ZipFile [v8]

2023-12-17 Thread Alan Bateman
On Mon, 11 Dec 2023 05:47:33 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982) >> which overrides and provides an implementation of `toString()` in >> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_). > > Justin Lu has updat

Re: RFR: JDK-8319626: Override toString() for ZipFile [v8]

2023-12-19 Thread Sean Coffey
On Mon, 11 Dec 2023 05:47:33 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982) >> which overrides and provides an implementation of `toString()` in >> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_). > > Justin Lu has updat