Re: RFR: JDK-8321545: Override toString() for Format subclasses [v6]

2024-01-23 Thread Justin Lu
> Please review this PR which implements toString() for the `Format` > subclasses. Corresponding CSR: > [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088) > > The general specification follows a template that provides the locale (if the > class is localized) and any relevant patterns. T

Re: RFR: JDK-8321545: Override toString() for Format subclasses [v5]

2024-01-23 Thread Roger Riggs
On Fri, 12 Jan 2024 22:41:46 GMT, Justin Lu wrote: >> Please review this PR which implements toString() for the `Format` >> subclasses. Corresponding CSR: >> [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088) >> >> The general specification follows a template that provides the locale (

Re: RFR: JDK-8321545: Override toString() for Format subclasses [v4]

2024-01-22 Thread Justin Lu
On Fri, 12 Jan 2024 21:30:05 GMT, Roger Riggs wrote: >> Justin Lu has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains eight additional commits >> si

Re: RFR: JDK-8321545: Override toString() for Format subclasses [v5]

2024-01-12 Thread Justin Lu
> Please review this PR which implements toString() for the `Format` > subclasses. Corresponding CSR: > [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088) > > The general specification follows a template that provides the locale (if the > class is localized) and any relevant patterns. T

Re: RFR: JDK-8321545: Override toString() for Format subclasses [v4]

2024-01-12 Thread Roger Riggs
On Fri, 12 Jan 2024 19:07:46 GMT, Justin Lu wrote: >> Please review this PR which implements toString() for the `Format` >> subclasses. Corresponding CSR: >> [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088) >> >> The general specification follows a template that provides the locale (

Re: RFR: JDK-8321545: Override toString() for Format subclasses [v4]

2024-01-12 Thread Naoto Sato
On Fri, 12 Jan 2024 19:07:46 GMT, Justin Lu wrote: >> Please review this PR which implements toString() for the `Format` >> subclasses. Corresponding CSR: >> [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088) >> >> The general specification follows a template that provides the locale (

Re: RFR: JDK-8321545: Override toString() for Format subclasses [v4]

2024-01-12 Thread Justin Lu
> Please review this PR which implements toString() for the `Format` > subclasses. Corresponding CSR: > [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088) > > The general specification follows a template that provides the locale (if the > class is localized) and any relevant patterns. T

Re: RFR: JDK-8321545: Override toString() for Format subclasses [v3]

2024-01-12 Thread Naoto Sato
On Fri, 12 Jan 2024 18:27:55 GMT, Justin Lu wrote: >> Please review this PR which implements toString() for the `Format` >> subclasses. Corresponding CSR: >> [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088) >> >> The general specification follows a template that provides the locale (

Re: RFR: JDK-8321545: Override toString() for Format subclasses [v2]

2024-01-12 Thread Justin Lu
On Thu, 11 Jan 2024 19:42:42 GMT, Naoto Sato wrote: > I think test cases for these new overridden `toString()` methods would be > helpful. Added test cases for the new methods. Additionally, in the most recent commit, I swapped the placement of `compact patterns` with `decimal pattern`. As `c

Re: RFR: JDK-8321545: Override toString() for Format subclasses [v3]

2024-01-12 Thread Justin Lu
> Please review this PR which implements toString() for the `Format` > subclasses. Corresponding CSR: > [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088) > > The general specification follows a template that provides the locale (if the > class is localized) and any relevant patterns. T

Re: RFR: JDK-8321545: Override toString() for Format subclasses [v2]

2024-01-11 Thread Naoto Sato
On Thu, 11 Jan 2024 19:30:09 GMT, Justin Lu wrote: >> Please review this PR which implements toString() for the `Format` >> subclasses. Corresponding CSR: >> [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088) >> >> The general specification follows a template that provides the locale (

Re: RFR: JDK-8321545: Override toString() for Format subclasses [v2]

2024-01-11 Thread Justin Lu
> Please review this PR which implements toString() for the `Format` > subclasses. Corresponding CSR: > [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088) > > The general specification follows a template that provides the locale (if the > class is localized) and any relevant patterns. T

RFR: JDK-8321545: Override toString() for Format subclasses

2024-01-10 Thread Justin Lu
Please review this PR which implements toString() for the `Format` subclasses. Corresponding CSR: [JDK-8323088](https://bugs.openjdk.org/browse/JDK-8323088) The general specification follows a template that provides the locale (if the class is localized) and any relevant patterns. The specificat