RFR: JDK-8322235: Split up and improve LocaleProvidersRun

2024-01-03 Thread Justin Lu
Please review this PR which splits up the _LocaleProvidersRun_ test file for performance and maintenance reasons. _LocaleProvidersRun_ which tests against the various Locale Providers (CLDR, HOST, SPI, etc.) was getting rather long, as all related bugs were added to the single test file. To imp

Re: RFR: JDK-8322235: Split up and improve LocaleProvidersRun

2024-01-04 Thread Naoto Sato
On Wed, 3 Jan 2024 23:30:41 GMT, Justin Lu wrote: > Please review this PR which splits up the _LocaleProvidersRun_ test file for > performance and maintenance reasons. > > _LocaleProvidersRun_ which tests against the various Locale Providers (CLDR, > HOST, SPI, etc.) was getting rather long, a

Re: RFR: JDK-8322235: Split up and improve LocaleProvidersRun [v2]

2024-01-04 Thread Justin Lu
On Thu, 4 Jan 2024 19:01:31 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - cleanup comments >> - provide both SPI classes under build for relevant test files > > test/jdk/java/util/Locale/LocalePro

Re: RFR: JDK-8322235: Split up and improve LocaleProvidersRun [v2]

2024-01-04 Thread Justin Lu
> Please review this PR which splits up the _LocaleProvidersRun_ test file for > performance and maintenance reasons. > > _LocaleProvidersRun_ which tests against the various Locale Providers (CLDR, > HOST, SPI, etc.) was getting rather long, as all related bugs were added to > the single test

Re: RFR: JDK-8322235: Split up and improve LocaleProvidersRun [v2]

2024-01-04 Thread Naoto Sato
On Thu, 4 Jan 2024 19:30:00 GMT, Justin Lu wrote: >> Please review this PR which splits up the _LocaleProvidersRun_ test file for >> performance and maintenance reasons. >> >> _LocaleProvidersRun_ which tests against the various Locale Providers (CLDR, >> HOST, SPI, etc.) was getting rather lo

Re: RFR: JDK-8322235: Split up and improve LocaleProvidersRun [v3]

2024-01-10 Thread Justin Lu
> Please review this PR which splits up the _LocaleProvidersRun_ test file for > performance and maintenance reasons. > > _LocaleProvidersRun_ which tests against the various Locale Providers (CLDR, > HOST, SPI, etc.) was getting rather long, as all related bugs were added to > the single test

Re: RFR: JDK-8322235: Split up and improve LocaleProvidersRun [v3]

2024-01-10 Thread Naoto Sato
On Wed, 10 Jan 2024 21:05:53 GMT, Justin Lu wrote: >> Please review this PR which splits up the _LocaleProvidersRun_ test file for >> performance and maintenance reasons. >> >> _LocaleProvidersRun_ which tests against the various Locale Providers (CLDR, >> HOST, SPI, etc.) was getting rather l

Re: RFR: JDK-8322235: Split up and improve LocaleProvidersRun [v3]

2024-01-10 Thread Justin Lu
On Wed, 10 Jan 2024 21:23:48 GMT, Naoto Sato wrote: > Still looks good. Please modify the copyright year for > `HostLocaleProviderAdapter_md.c` file before integrating Totally missed that, thanks for catching. Will integrate after re-testing VM tiers. - PR Comment: https://git.op

Re: RFR: JDK-8322235: Split up and improve LocaleProvidersRun [v4]

2024-01-10 Thread Justin Lu
> Please review this PR which splits up the _LocaleProvidersRun_ test file for > performance and maintenance reasons. > > _LocaleProvidersRun_ which tests against the various Locale Providers (CLDR, > HOST, SPI, etc.) was getting rather long, as all related bugs were added to > the single test