Re: RFR: JDK-8322512 StringBuffer.repeat does not work correctly after toString() was called [v2]

2024-01-04 Thread Jim Laskey
On Thu, 21 Dec 2023 07:55:50 GMT, Jaikiran Pai wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Clear sooner > > test/jdk/java/lang/StringBuilder/StringBufferRepeat.java line 138: > >> 136: sb.repeat('*',

Re: RFR: JDK-8322512 StringBuffer.repeat does not work correctly after toString() was called [v4]

2024-01-04 Thread Jim Laskey
> The new repeat methods were not clearing the toStringCache. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Nit in test - Changes: - all: https://git.openjdk.org/jdk/pull/17172/files - new:

Re: RFR: JDK-8322512 StringBuffer.repeat does not work correctly after toString() was called [v3]

2024-01-04 Thread Jim Laskey
> The new repeat methods were not clearing the toStringCache. Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since

Re: RFR: JDK-8322512 StringBuffer.repeat does not work correctly after toString() was called [v2]

2023-12-21 Thread Jaikiran Pai
On Wed, 20 Dec 2023 22:18:08 GMT, Jim Laskey wrote: >> The new repeat methods were not clearing the toStringCache. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > Clear sooner The changes look good to me. I just have a

Re: RFR: JDK-8322512 StringBuffer.repeat does not work correctly after toString() was called [v2]

2023-12-20 Thread Jim Laskey
On Wed, 20 Dec 2023 21:52:40 GMT, Roger Riggs wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Clear sooner > > src/java.base/share/classes/java/lang/StringBuffer.java line 719: > >> 717: public synchronized

Re: RFR: JDK-8322512 StringBuffer.repeat does not work correctly after toString() was called [v2]

2023-12-20 Thread Jim Laskey
> The new repeat methods were not clearing the toStringCache. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Clear sooner - Changes: - all: https://git.openjdk.org/jdk/pull/17172/files - new:

Re: RFR: JDK-8322512 StringBuffer.repeat does not work correctly after toString() was called [v2]

2023-12-20 Thread Markus KARG
On Wed, 20 Dec 2023 22:15:04 GMT, Jim Laskey wrote: >> The new repeat methods were not clearing the toStringCache. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > Clear sooner LGTM. - Marked as reviewed by

Re: RFR: JDK-8322512 StringBuffer.repeat does not work correctly after toString() was called [v2]

2023-12-20 Thread Roger Riggs
On Wed, 20 Dec 2023 22:15:04 GMT, Jim Laskey wrote: >> The new repeat methods were not clearing the toStringCache. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > Clear sooner LGTM - Marked as reviewed by

Re: RFR: JDK-8322512 StringBuffer.repeat does not work correctly after toString() was called

2023-12-20 Thread Roger Riggs
On Wed, 20 Dec 2023 20:25:07 GMT, Jim Laskey wrote: > The new repeat methods were not clearing the toStringCache. src/java.base/share/classes/java/lang/StringBuffer.java line 719: > 717: public synchronized StringBuffer repeat(int codePoint, int count) { > 718:

RFR: JDK-8322512 StringBuffer.repeat does not work correctly after toString() was called

2023-12-20 Thread Jim Laskey
The new repeat methods were not clearing the toStringCache. - Commit messages: - Clear toStringCache when calling StringBuffer::repeat Changes: https://git.openjdk.org/jdk/pull/17172/files Webrev: https://webrevs.openjdk.org/?repo=jdk=17172=00 Issue: