On Thu, 21 Dec 2023 07:55:50 GMT, Jaikiran Pai wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clear sooner
>
> test/jdk/java/lang/StringBuilder/StringBufferRepeat.java line 138:
>
>> 136: sb.repeat('*',
> The new repeat methods were not clearing the toStringCache.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Nit in test
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17172/files
- new:
> The new repeat methods were not clearing the toStringCache.
Jim Laskey has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains three additional commits since
On Wed, 20 Dec 2023 22:18:08 GMT, Jim Laskey wrote:
>> The new repeat methods were not clearing the toStringCache.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Clear sooner
The changes look good to me. I just have a
On Wed, 20 Dec 2023 21:52:40 GMT, Roger Riggs wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clear sooner
>
> src/java.base/share/classes/java/lang/StringBuffer.java line 719:
>
>> 717: public synchronized
> The new repeat methods were not clearing the toStringCache.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Clear sooner
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17172/files
- new:
On Wed, 20 Dec 2023 22:15:04 GMT, Jim Laskey wrote:
>> The new repeat methods were not clearing the toStringCache.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Clear sooner
LGTM.
-
Marked as reviewed by
On Wed, 20 Dec 2023 22:15:04 GMT, Jim Laskey wrote:
>> The new repeat methods were not clearing the toStringCache.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Clear sooner
LGTM
-
Marked as reviewed by
On Wed, 20 Dec 2023 20:25:07 GMT, Jim Laskey wrote:
> The new repeat methods were not clearing the toStringCache.
src/java.base/share/classes/java/lang/StringBuffer.java line 719:
> 717: public synchronized StringBuffer repeat(int codePoint, int count) {
> 718:
The new repeat methods were not clearing the toStringCache.
-
Commit messages:
- Clear toStringCache when calling StringBuffer::repeat
Changes: https://git.openjdk.org/jdk/pull/17172/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=17172=00
Issue:
10 matches
Mail list logo