Re: RFR: JDK-8325255 jdk.internal.util.ReferencedKeySet::add using wrong test [v4]

2024-03-09 Thread Jim Laskey
The class is used in java.lang.invoke.MethodType but add is not used. 📱 > On Mar 9, 2024, at 11:42 AM, Chen Liang wrote: > > On Tue, 5 Mar 2024 20:23:56 GMT, Jim Laskey wrote: > >>> Currently, add is returning intern(e) == null which will always be false. >>> The correct test is intern(e)

Re: RFR: JDK-8325255 jdk.internal.util.ReferencedKeySet::add using wrong test [v4]

2024-03-09 Thread Chen Liang
On Tue, 5 Mar 2024 20:23:56 GMT, Jim Laskey wrote: >> Currently, add is returning intern(e) == null which will always be false. >> The correct test is intern(e) == e , that is, true when element is newly >> added. > > Jim Laskey has updated the pull request incrementally with one additional >

Re: RFR: JDK-8325255 jdk.internal.util.ReferencedKeySet::add using wrong test [v4]

2024-03-09 Thread ExE Boss
On Tue, 5 Mar 2024 20:23:56 GMT, Jim Laskey wrote: >> Currently, add is returning intern(e) == null which will always be false. >> The correct test is intern(e) == e , that is, true when element is newly >> added. > > Jim Laskey has updated the pull request incrementally with one additional >

Re: RFR: JDK-8325255 jdk.internal.util.ReferencedKeySet::add using wrong test [v4]

2024-03-05 Thread Roger Riggs
On Tue, 5 Mar 2024 20:23:56 GMT, Jim Laskey wrote: >> Currently, add is returning intern(e) == null which will always be false. >> The correct test is intern(e) == e , that is, true when element is newly >> added. > > Jim Laskey has updated the pull request incrementally with one additional >

Re: RFR: JDK-8325255 jdk.internal.util.ReferencedKeySet::add using wrong test [v4]

2024-03-05 Thread Chen Liang
On Tue, 5 Mar 2024 20:23:56 GMT, Jim Laskey wrote: >> Currently, add is returning intern(e) == null which will always be false. >> The correct test is intern(e) == e , that is, true when element is newly >> added. > > Jim Laskey has updated the pull request incrementally with one additional >

Re: RFR: JDK-8325255 jdk.internal.util.ReferencedKeySet::add using wrong test [v4]

2024-03-05 Thread Jim Laskey
> Currently, add is returning intern(e) == null which will always be false. The > correct test is intern(e) == e , that is, true when element is newly added. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: Fix ReferencedKeySet::add --