On Wed, 19 Jul 2023 00:52:49 GMT, Chen Liang wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review feedback
>
> src/java.base/share/classes/java/lang/invoke/IndirectVarHandle.java line 93:
>
>> 91: @ForceInlin
> `VarForm::getMemberName` currently throws UOE with no information if the
> requested access mode is unsupported. To provide the var handle
> information, move the access mode check to `VarHandle` so that the exception
> message can include the var handle information. Changes include:
>
> 1
On Wed, 19 Jul 2023 02:19:58 GMT, Mandy Chung wrote:
>> `VarForm::getMemberName` currently throws UOE with no information if the
>> requested access mode is unsupported. To provide the var handle
>> information, move the access mode check to `VarHandle` so that the exception
>> message can i
On Wed, 19 Jul 2023 02:19:58 GMT, Mandy Chung wrote:
>> `VarForm::getMemberName` currently throws UOE with no information if the
>> requested access mode is unsupported. To provide the var handle
>> information, move the access mode check to `VarHandle` so that the exception
>> message can i
On Wed, 19 Jul 2023 23:37:41 GMT, Jorn Vernee wrote:
> Note that `IndirectVarHandle` calls `super.checkAccessModeThenIsDirect`, so
> it ends up doing the check any way, I think?
In the initial patch, it was distinct; it was migrated to call
`isAccessModeSupported` in a subsequent change, so th
On Wed, 19 Jul 2023 02:19:58 GMT, Mandy Chung wrote:
>> `VarForm::getMemberName` currently throws UOE with no information if the
>> requested access mode is unsupported. To provide the var handle
>> information, move the access mode check to `VarHandle` so that the exception
>> message can i
On Wed, 19 Jul 2023 02:19:58 GMT, Mandy Chung wrote:
>> `VarForm::getMemberName` currently throws UOE with no information if the
>> requested access mode is unsupported. To provide the var handle
>> information, move the access mode check to `VarHandle` so that the exception
>> message can i
