Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-21 Thread Coleen Phillimore
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote: >> This patch moves the acquisition of the boot class loader lock out of the >> JVM and into the Java function. >> Tested with tier1-4, and jvmti and jdi tests locally. > > Coleen Phillimore has updated the pull request incrementally

Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-20 Thread David Holmes
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote: >> This patch moves the acquisition of the boot class loader lock out of the >> JVM and into the Java function. >> Tested with tier1-4, and jvmti and jdi tests locally. > > Coleen Phillimore has updated the pull request incrementally

Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-18 Thread Alan Bateman
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote: >> This patch moves the acquisition of the boot class loader lock out of the >> JVM and into the Java function. >> Tested with tier1-4, and jvmti and jdi tests locally. > > Coleen Phillimore has updated the pull request incrementally

Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-18 Thread Coleen Phillimore
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote: >> This patch moves the acquisition of the boot class loader lock out of the >> JVM and into the Java function. >> Tested with tier1-4, and jvmti and jdi tests locally. > > Coleen Phillimore has updated the pull request incrementally

Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-16 Thread Coleen Phillimore
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote: >> This patch moves the acquisition of the boot class loader lock out of the >> JVM and into the Java function. >> Tested with tier1-4, and jvmti and jdi tests locally. > > Coleen Phillimore has updated the pull request incrementally

Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-16 Thread David Holmes
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote: >> This patch moves the acquisition of the boot class loader lock out of the >> JVM and into the Java function. >> Tested with tier1-4, and jvmti and jdi tests locally. > > Coleen Phillimore has updated the pull request incrementally

Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-16 Thread Serguei Spitsyn
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote: >> This patch moves the acquisition of the boot class loader lock out of the >> JVM and into the Java function. >> Tested with tier1-4, and jvmti and jdi tests locally. > > Coleen Phillimore has updated the pull request incrementally

Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-16 Thread Coleen Phillimore
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote: >> This patch moves the acquisition of the boot class loader lock out of the >> JVM and into the Java function. >> Tested with tier1-4, and jvmti and jdi tests locally. > > Coleen Phillimore has updated the pull request incrementally

Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-15 Thread Coleen Phillimore
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote: >> This patch moves the acquisition of the boot class loader lock out of the >> JVM and into the Java function. >> Tested with tier1-4, and jvmti and jdi tests locally. > > Coleen Phillimore has updated the pull request incrementally

Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-09 Thread Alan Bateman
On Tue, 8 Nov 2022 23:45:18 GMT, David Holmes wrote: > "in the custom class loader must append to the class path in a thread-safe > manner." Maybe "its search path" rather than "the class path" because the custom class loader can't add to the class path (the application class path continues

Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-08 Thread David Holmes
On Tue, 8 Nov 2022 22:08:06 GMT, Coleen Phillimore wrote: > in the custom class loader must synchronize appending to the class path I would say: "in the custom class loader must append to the class path in a thread-safe manner." - PR: https://git.openjdk.org/jdk/pull/11023

Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-08 Thread Coleen Phillimore
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote: >> This patch moves the acquisition of the boot class loader lock out of the >> JVM and into the Java function. >> Tested with tier1-4, and jvmti and jdi tests locally. > > Coleen Phillimore has updated the pull request incrementally

Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-08 Thread Alan Bateman
On Tue, 8 Nov 2022 17:03:05 GMT, Coleen Phillimore wrote: > Can one create a class loader to override this function, and does one expect > the JVM to synchronize it on the system class loader object (returned by > getSystemClassLoader)? This feels too remote to try to explain in a CSR. > >

Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-08 Thread Coleen Phillimore
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote: >> This patch moves the acquisition of the boot class loader lock out of the >> JVM and into the Java function. >> Tested with tier1-4, and jvmti and jdi tests locally. > > Coleen Phillimore has updated the pull request incrementally

Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-08 Thread Alan Bateman
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote: >> This patch moves the acquisition of the boot class loader lock out of the >> JVM and into the Java function. >> Tested with tier1-4, and jvmti and jdi tests locally. > > Coleen Phillimore has updated the pull request incrementally

Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-08 Thread Alan Bateman
On Tue, 8 Nov 2022 04:23:13 GMT, David Holmes wrote: > Note the loader involved need not be our own default platform loader and we > don't know how a custom system loader might operate. The specification for > this says nothing about thread-safety, nor that the VM will do any locking, > so I

Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-07 Thread David Holmes
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote: >> This patch moves the acquisition of the boot class loader lock out of the >> JVM and into the Java function. >> Tested with tier1-4, and jvmti and jdi tests locally. > > Coleen Phillimore has updated the pull request incrementally

Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-07 Thread Serguei Spitsyn
On Mon, 7 Nov 2022 20:40:33 GMT, Coleen Phillimore wrote: >> This patch moves the acquisition of the boot class loader lock out of the >> JVM and into the Java function. >> Tested with tier1-4, and jvmti and jdi tests locally. > > Coleen Phillimore has updated the pull request incrementally

Re: RFR: 8296472: Remove ObjectLocker around appendToClassPathForInstrumentation call [v3]

2022-11-07 Thread Coleen Phillimore
> This patch moves the acquisition of the boot class loader lock out of the JVM > and into the Java function. > Tested with tier1-4, and jvmti and jdi tests locally. Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision: really revert