On Tue, 12 Dec 2023 11:59:36 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which adds validation of incorrect LOC signatures in
>> `ZipFileSystem`.
>>
>> `ZipFile` already rejects the case where the offset pointed to from the CEN
>> header does not start with the expected LOC signature.
On Tue, 12 Dec 2023 11:59:36 GMT, Eirik Bjorsnos wrote:
>> Please review this PR which adds validation of incorrect LOC signatures in
>> `ZipFileSystem`.
>>
>> `ZipFile` already rejects the case where the offset pointed to from the CEN
>> header does not start with the expected LOC signature.
On Tue, 12 Dec 2023 11:47:35 GMT, Lance Andersen wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use uppercase LOC in ZipException messages
>
> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 25
> Please review this PR which adds validation of incorrect LOC signatures in
> `ZipFileSystem`.
>
> `ZipFile` already rejects the case where the offset pointed to from the CEN
> header does not start with the expected LOC signature. It makes sense to add
> this check to `ZipFileSystem` as well