[core-workflow] Re: Workflow for the PR?

2018-07-31 Thread Stephane Wirtel
On 06/05, Stephane Wirtel wrote: On 05/23, Brett Cannon wrote: On Wed, 23 May 2018 at 06:59 Stephane Wirtel wrote: On 05/16, Brett Cannon wrote: On Tue, 15 May 2018 at 13:03 Berker Peksağ wrote: On Tue, May 15, 2018 at 6:12 PM, Stephane Wirtel wrote: > For me, normally, the label shoul

[core-workflow] Re: Workflow for the PR?

2018-06-05 Thread Stephane Wirtel
On 05/23, Brett Cannon wrote: On Wed, 23 May 2018 at 06:59 Stephane Wirtel wrote: On 05/16, Brett Cannon wrote: >On Tue, 15 May 2018 at 13:03 Berker Peksağ wrote: > >> On Tue, May 15, 2018 at 6:12 PM, Stephane Wirtel >> wrote: >> > For me, normally, the label should be on "awaiting changes"

[core-workflow] Re: Workflow for the PR?

2018-05-23 Thread Brett Cannon
On Wed, 23 May 2018 at 06:59 Stephane Wirtel wrote: > On 05/16, Brett Cannon wrote: > >On Tue, 15 May 2018 at 13:03 Berker Peksağ > wrote: > > > >> On Tue, May 15, 2018 at 6:12 PM, Stephane Wirtel > >> wrote: > >> > For me, normally, the label should be on "awaiting changes" and after > >> > a

[core-workflow] Re: Workflow for the PR?

2018-05-23 Thread Stephane Wirtel
On 05/16, Brett Cannon wrote: On Tue, 15 May 2018 at 13:03 Berker Peksağ wrote: On Tue, May 15, 2018 at 6:12 PM, Stephane Wirtel wrote: > For me, normally, the label should be on "awaiting changes" and after > a new commit/message from the author, the label should be "awaiting review" The re

[core-workflow] Re: Workflow for the PR?

2018-05-23 Thread Stephane Wirtel
On 05/15, Berker Peksağ wrote: On Tue, May 15, 2018 at 6:12 PM, Stephane Wirtel wrote: For me, normally, the label should be on "awaiting changes" and after a new commit/message from the author, the label should be "awaiting review" The reviewer wasn't a core developer so we need to get a app

[core-workflow] Re: Workflow for the PR?

2018-05-16 Thread Brett Cannon
On Tue, 15 May 2018 at 13:03 Berker Peksağ wrote: > On Tue, May 15, 2018 at 6:12 PM, Stephane Wirtel > wrote: > > For me, normally, the label should be on "awaiting changes" and after > > a new commit/message from the author, the label should be "awaiting > review" > > The reviewer wasn't a core

[core-workflow] Re: Workflow for the PR?

2018-05-15 Thread Berker Peksağ
On Tue, May 15, 2018 at 6:12 PM, Stephane Wirtel wrote: > For me, normally, the label should be on "awaiting changes" and after > a new commit/message from the author, the label should be "awaiting review" The reviewer wasn't a core developer so we need to get a approval/review from a core develo