On 10/10/2017 11:51 AM, Brett Cannon wrote:
I just merged the PR and went with "I have made the requested changes; please review
again". Figured this makes people
aware that they are to have addressed the changes before requesting a review and has them
saying "please". :) Plus
there's no way a
I just merged the PR and went with "I have made the requested changes;
please review again". Figured this makes people aware that they are to have
addressed the changes before requesting a review and has them saying
"please". :) Plus there's no way anyone will accidentally type that in
conversation
On 10/08/2017 09:44 AM, Brett Cannon wrote:
I actually wouldn't want the bot name in the trigger phrase since you're not
addressing the bot but the reviewer(s). So
using something that is unambiguous as a trigger phrase like "please re-review" or
"please review again" that won't come
up in con
See https://github.com/python/bedevere/pull/66 for a PR to support an
additional, more muted trigger phrase (currently "Please review again").
On Sun, 8 Oct 2017 at 09:44 Brett Cannon wrote:
> On Sun, 8 Oct 2017 at 00:55 Nick Coghlan wrote:
>
>> On 8 October 2017 at 07:38, Donald Stufft wrote:
On Sun, 8 Oct 2017 at 00:55 Nick Coghlan wrote:
> On 8 October 2017 at 07:38, Donald Stufft wrote:
>
>> Currently the workflow for CPython development requires people to say 'I
>> didn't expect the Spanish Inquisition’ in order to request a re-review of
>> their work. Can we please use a phrase
On 8 October 2017 at 07:38, Donald Stufft wrote:
> Currently the workflow for CPython development requires people to say 'I
> didn't expect the Spanish Inquisition’ in order to request a re-review of
> their work. Can we please use a phrase for this that makes more sense
> rather than, as Alex pu
On Sat, Oct 7, 2017 at 5:38 PM, Donald Stufft wrote:
> .. Leave it in as an Easter egg if you like (and probably should for
> backwards compatibility
> anyways), but please make something else be the primary phrase.
>
I didn't expect the Spanish Inquisition. :-)
Currently the workflow for CPython development requires people to say 'I didn't
expect the Spanish Inquisition’ in order to request a re-review of their work.
Can we please use a phrase for this that makes more sense rather than, as Alex
put it, “magic inside baseball language”.
In jokes can be
