[coreboot] [PATCH] remove annoying noisy message

See patch The error message is misleading, even for a SPEW, because the slot is empty, it's NOT a bad ID (and the message is more confusing than helpful even in SPEW) Signed-off-by: Stefan Reinauer Index: src/devices/pci_device.c =

Re: [coreboot] [PATCH] remove annoying noisy message

On Fri, Apr 2, 2010 at 9:04 AM, Stefan Reinauer wrote: > See patch I'm mixed on this one, but at the same time, I bet there are few broken devices that return 0 as there were in the old days. Acked-by: Ronald G. Minnich -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/m

Re: [coreboot] [PATCH] remove annoying noisy message

On 4/2/10 6:09 PM, ron minnich wrote: > On Fri, Apr 2, 2010 at 9:04 AM, Stefan Reinauer wrote: > >> See patch >> > I'm mixed on this one, but at the same time, I bet there are few > broken devices that return 0 as there were in the old days. I wonder, what would we do with them if we knew.

[coreboot] [FILO] r122 - trunk/filo

Author: stepan Date: Fri Apr 2 18:18:59 2010 New Revision: 122 URL: http://tracker.coreboot.org/trac/filo/changeset/122 Log: As suggested by Wang Qing Pei: Fix FILO compilation without extra parameters on AMD64 Signed-off-by: Wang Qing Pei Signed-off-by: Stefan Reinauer Modified: trunk/fi

Re: [coreboot] patch for avoding amd64 compiling error

On 3/31/10 7:32 PM, Qing Pei Wang wrote: > Signed-off-by: Wang Qing Pei > slightly modified and checked in as r122 -- coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br. Tel.: +49 761 7668825 • Fax: +49 761 7664613 Email: i...@coresystems.de • http://ww

Re: [coreboot] [PATCH] remove annoying noisy message

> I'm mixed on this one, but at the same time, I bet there are few > broken devices that return 0 as there were in the old days. In that case the check could be split, so that the message is only printed in the cases where it isn't 0x. Then only the broken boards would print the message.

Re: [coreboot] [PATCH] remove annoying noisy message

> Maybe we should only print the message if something else than 0x > is read? Would that be more appropriate? > 0x is the expected read-back if there is no device, and I think > that case should not be reported as "bad id" > > Like the attached one Acked-by: Myles Watson Thanks,

[coreboot] [commit] r5345 - trunk/src/devices

Author: stepan Date: Fri Apr 2 18:30:25 2010 New Revision: 5345 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5345 Log: The error message is misleading, even for a SPEW, because the slot is empty, it's NOT a bad ID (and the message is more confusing than helpful even in SPEW) Signed-

[coreboot] [commit] r5346 - trunk/src/northbridge/amd/amdk8

Author: myles Date: Fri Apr 2 22:14:21 2010 New Revision: 5346 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5346 Log: Fix includes for showallroutes. Signed-off-by: Myles Watson Acked-by: Myles Watson Modified: trunk/src/northbridge/amd/amdk8/amdk8.h trunk/src/northbridge/a

[coreboot] [commit] r5347 - in trunk/src/include: . console

Author: myles Date: Fri Apr 2 23:39:12 2010 New Revision: 5347 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5347 Log: Fix console prototypes for non-romcc boards. Signed-off-by: Myles Watson Acked-by: Myles Watson Modified: trunk/src/include/console/console.h trunk/src/incl

[coreboot] [commit] r5348 - in trunk/src: cpu/amd/model_gx2 include/console mainboard/advantech/pcm-5820 mainboard/amd/db800 northbridge/amd/lx southbridge/amd/cs5536

Author: stepan Date: Sat Apr 3 00:11:20 2010 New Revision: 5348 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5348 Log: remove some more warnings Signed-off-by: Stefan Reinauer Acked-by: Stefan Reinauer Modified: trunk/src/cpu/amd/model_gx2/vsmsetup.c trunk/src/include/conso

[coreboot] [commit] r5349 - trunk/src/include/console

Author: stepan Date: Sat Apr 3 00:13:27 2010 New Revision: 5349 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5349 Log: oops, sorry, overlapping work Signed-off-by: Stefan Reinauer Acked-by: Stefan Reinauer Modified: trunk/src/include/console/console.h Modified: trunk/src/inclu

Re: [coreboot] [PATCH] continue cleaning up log levels

On 4/2/10 7:55 PM, Myles Watson wrote: > loglevel.diff: > Remove BIOS_EMERG, BIOS_ALERT, BIOS_CRIT, BIOS_NOTICE, BIOS_NEVER I am not convinced that's a good idea. But let's hear what other people say... > I didn't change their numerical values. They were rarely used. > BIOS_EMERG, BIOS_ALERT, BIO

[coreboot] [commit] r5350 - in trunk/src: cpu/amd/model_gx2 northbridge/amd/amdht northbridge/amd/gx2 southbridge/amd/rs780

Author: stepan Date: Sat Apr 3 00:31:35 2010 New Revision: 5350 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5350 Log: remove more warnings. Signed-off-by: Stefan Reinauer Acked-by: Stefan Reinauer Modified: trunk/src/cpu/amd/model_gx2/cpubug.c trunk/src/northbridge/amd/amdh

Re: [coreboot] [PATCH] continue cleaning up log levels

On Fri, Apr 2, 2010 at 4:19 PM, Stefan Reinauer wrote: > On 4/2/10 7:55 PM, Myles Watson wrote: > > loglevel.diff: > Remove BIOS_EMERG, BIOS_ALERT, BIOS_CRIT, BIOS_NOTICE, BIOS_NEVER > > I am not convinced that's a good idea. But let's hear what other people > say... > They were used so infrequen

Re: [coreboot] [PATCH] continue cleaning up log levels

> >> BIOS_NEVER -> BIOS_SPEW+1 >> >> The whole intent was to make clear to the reader that this is something >> that's never seen. ;-) >> That doesn't become clear from BIOS_SPEW+1 in my opinion. >> > NEVER was only used once or twice in the code. If it's something that will > be used more often,

Re: [coreboot] [commit] r5348 - in trunk/src: cpu/amd/model_gx2 include/console mainboard/advantech/pcm-5820 mainboard/amd/db800 northbridge/amd/lx southbridge/amd/cs5536

> > Modified: trunk/src/include/console/console.h > > == > --- trunk/src/include/console/console.h Fri Apr 2 23:39:12 2010 > (r5347) > +++ trunk/src/include/console/console.h Sat Apr 3 00:11:20 2010 > (r5348) > @@ -44,6

Re: [coreboot] [PATCH] continue cleaning up log levels

On 04/02/2010 06:19 PM, Stefan Reinauer wrote: On 4/2/10 7:55 PM, Myles Watson wrote: loglevel.diff: Remove BIOS_EMERG, BIOS_ALERT, BIOS_CRIT, BIOS_NOTICE, BIOS_NEVER I am not convinced that's a good idea. But let's hear what other people say... I didn't change their numerical values. They wer

[coreboot] [commit] r5351 - trunk/util/romcc

Author: stepan Date: Sat Apr 3 02:03:07 2010 New Revision: 5351 URL: https://tracker.coreboot.org/trac/coreboot/changeset/5351 Log: Add noreturn attribute to die() in romcc. This makes life a lot easier for static analyzers such as scan-build. Signed-off-by: Stefan Reinauer Acked-by: Stefan Rein

[coreboot] build service results for r5348

Dear coreboot readers! This is the automatic build system of coreboot. The developer "stepan" checked in revision 5348 to the coreboot repository. This caused the following changes: Change Log: remove some more warnings Signed-off-by: Stefan Reinauer Acked-by: Stefan Reinauer Build Log: C