[coreboot] [PATCH 4/5] libpayload: Implement pci_cleanup() to make flashrom happy

2011-02-25 Thread Patrick Georgi
Signed-off-by: Patrick Georgi patrick.geo...@secunet.com --- payloads/libpayload/include/pci/pci.h |1 + payloads/libpayload/libpci/libpci.c |6 +- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/payloads/libpayload/include/pci/pci.h

[coreboot] [PATCH 1/5] libpayload: Add lib/ to the default library path of lpgcc, so -l works

2011-02-25 Thread Patrick Georgi
Signed-off-by: Patrick Georgi patrick.geo...@secunet.com --- payloads/libpayload/bin/lpgcc |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/payloads/libpayload/bin/lpgcc b/payloads/libpayload/bin/lpgcc index 57015d5..80c2266 100755 --- a/payloads/libpayload/bin/lpgcc

[coreboot] [PATCH 5/5] libpayload: Add more libpci-compatibility (#defines)

2011-02-25 Thread Patrick Georgi
Signed-off-by: Patrick Georgi patrick.geo...@secunet.com --- payloads/libpayload/include/pci.h |2 ++ payloads/libpayload/include/pci/pci.h | 26 ++ 2 files changed, 28 insertions(+), 0 deletions(-) diff --git a/payloads/libpayload/include/pci.h

[coreboot] [PATCH 2/5] libpayload: Some more standard types and defines

2011-02-25 Thread Patrick Georgi
Signed-off-by: Patrick Georgi patrick.geo...@secunet.com --- payloads/libpayload/include/limits.h |2 ++ payloads/libpayload/include/stdint.h |5 + 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/payloads/libpayload/include/limits.h

[coreboot] [PATCH 3/5] libpayload: Implement ffs()

2011-02-25 Thread Patrick Georgi
Signed-off-by: Patrick Georgi patrick.geo...@secunet.com --- payloads/libpayload/include/strings.h | 35 payloads/libpayload/libc/Makefile.inc |2 +- payloads/libpayload/libc/strings.c| 40 + 3 files changed, 76

[coreboot] [PATCH] outb(* 0x80) to post_code()

2011-02-25 Thread Alex G.
Applies to fresh svn...[OK] abuild run..[OK] See patch. Alex Index: src/southbridge/via/vt8231/early_smbus.c === --- src/southbridge/via/vt8231/early_smbus.c (revision 6380)

Re: [coreboot] [PATCH] outb(* 0x80) to post_code()

2011-02-25 Thread Alex G.
Remove all occurences of outb(*, 0x80), and replace them with post_code(). Create post_codes.h to store a central place for post codes. Replace common post_codes with macros defined in post_codes.h. Signed-off-by: Alexandru Gagniuc mr.nuke...@gmail.com --- Oops, forgot to include that. --

Re: [coreboot] [PATCH] outb(* 0x80) to post_code()

2011-02-25 Thread Alex G.
Find attached the version with the colloquial verbiage abridged. Alex Remove all occurences of outb(*, 0x80), and replace them with post_code(). Create post_codes.h to store a central place for post codes. Replace common post_codes with macros defined in post_codes.h. Signed-off-by: Alexandru

Re: [coreboot] Coreboot for AMD Fusion family 14h: ASRock E350M1

2011-02-25 Thread Stefan Reinauer
* Scott Duplichan sc...@notabs.org [110225 02:02]: Stefan Reinauer wrote: ] +#define SERIAL_DEV PNP_DEV(0x2e, W83627HF_SP1) ]if CONFIG_SIO_PORT is defined in Kconfig (why?) we could as well use it ]in romstage.c. Is there a chance to remove it from Kconfig instead? Certainly the two

[coreboot] [FILO] r141 - in trunk/filo: fs i386

2011-02-25 Thread repository service
Author: stepan Date: Fri Feb 25 21:34:31 2011 New Revision: 141 URL: http://tracker.coreboot.org/trac/filo/changeset/141 Log: When using Artec loader and no file system, use dev_name for initrd instead of flashb. Signed-off-by: Nathan Williams nat...@traverse.com.au Modified:

[coreboot] [FILO] r142 - trunk/filo/i386

2011-02-25 Thread repository service
Author: stepan Date: Fri Feb 25 21:35:07 2011 New Revision: 142 URL: http://tracker.coreboot.org/trac/filo/changeset/142 Log: load_linux_kernel() checks using_devsize, so we need to clear it if we are using Artec loader without a file system. Signed-off-by: Nathan Williams nat...@traverse.com.au

Re: [coreboot] [PATCH] [FILO] Artec loader with initrd

2011-02-25 Thread Stefan Reinauer
* Nathan Williams nat...@traverse.com.au [110225 03:08]: When using Artec loader and no file system, use dev_name for initrd instead of flashb. Signed-off-by: Nathan Williams nat...@traverse.com.au Thanks, r141 -- coreboot mailing list: coreboot@coreboot.org

Re: [coreboot] [PATCH] [FILO] Artec loader with NULLFS

2011-02-25 Thread Stefan Reinauer
* Nathan Williams nat...@traverse.com.au [110225 03:34]: load_linux_kernel() checks using_devsize, so we need to clear it if we are using Artec loader without a file system. Signed-off-by: Nathan Williams nat...@traverse.com.au Thanks, r142 -- coreboot mailing list: coreboot@coreboot.org

Re: [coreboot] [PATCH 2/5] libpayload: Some more standard types and defines

2011-02-25 Thread Stefan Reinauer
* Patrick Georgi patrick.geo...@secunet.com [110225 13:02]: Signed-off-by: Patrick Georgi patrick.geo...@secunet.com --- payloads/libpayload/include/limits.h |2 ++ payloads/libpayload/include/stdint.h |5 + 2 files changed, 7 insertions(+), 0 deletions(-) Acked-by: Stefan

Re: [coreboot] [PATCH 3/5] libpayload: Implement ffs()

2011-02-25 Thread Stefan Reinauer
* Patrick Georgi patrick.geo...@secunet.com [110225 13:11]: Signed-off-by: Patrick Georgi patrick.geo...@secunet.com --- payloads/libpayload/include/strings.h | 35 payloads/libpayload/libc/Makefile.inc |2 +- payloads/libpayload/libc/strings.c| 40

Re: [coreboot] [PATCH 5/5] libpayload: Add more libpci-compatibility (#defines)

2011-02-25 Thread Stefan Reinauer
* Patrick Georgi patrick.geo...@secunet.com [110225 13:40]: Signed-off-by: Patrick Georgi patrick.geo...@secunet.com --- payloads/libpayload/include/pci.h |2 ++ payloads/libpayload/include/pci/pci.h | 26 ++ 2 files changed, 28 insertions(+), 0 deletions(-)

Re: [coreboot] [PATCH 1/5] libpayload: Add lib/ to the default library path of lpgcc, so -l works

2011-02-25 Thread Stefan Reinauer
* Patrick Georgi patrick.geo...@secunet.com [110225 14:09]: Signed-off-by: Patrick Georgi patrick.geo...@secunet.com --- payloads/libpayload/bin/lpgcc |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) Acked-by: Stefan Reinauer stefan.reina...@coreboot.org -- coreboot mailing

Re: [coreboot] [PATCH 4/5] libpayload: Implement pci_cleanup() to make flashrom happy

2011-02-25 Thread Stefan Reinauer
* Patrick Georgi patrick.geo...@secunet.com [110225 14:09]: Signed-off-by: Patrick Georgi patrick.geo...@secunet.com --- payloads/libpayload/include/pci/pci.h |1 + payloads/libpayload/libpci/libpci.c |6 +- 2 files changed, 6 insertions(+), 1 deletions(-) Acked-by: Stefan

Re: [coreboot] [PATCH 3/5] libpayload: Implement ffs()

2011-02-25 Thread Peter Stuge
Patrick Georgi wrote: +int ffs(int i); Wording in my ffs(3) page suggests that int can be 64 bit. We don't care? //Peter -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot

Re: [coreboot] [PATCH] outb(* 0x80) to post_code()

2011-02-25 Thread Stefan Reinauer
* Alex G. mr.nuke...@gmail.com [110225 18:48]: Find attached the version with the colloquial verbiage abridged. Alex Remove all occurences of outb(*, 0x80), and replace them with post_code(). Create post_codes.h to store a central place for post codes. Replace common post_codes with

Re: [coreboot] [PATCH 2/5] libpayload: Some more standard types and defines

2011-02-25 Thread Stefan Reinauer
* Peter Stuge pe...@stuge.se [110225 21:45]: Patrick Georgi wrote: +++ b/payloads/libpayload/include/stdint.h @@ -27,4 +27,9 @@ * SUCH DAMAGE. */ +#ifndef __STDINT_H +#define __STDINT_H #include arch/types.h + +typedef unsigned long uintptr_t; +#endif What about 64

Re: [coreboot] [PATCH 3/5] libpayload: Implement ffs()

2011-02-25 Thread Stefan Reinauer
* Peter Stuge pe...@stuge.se [110225 21:48]: Patrick Georgi wrote: +int ffs(int i); Wording in my ffs(3) page suggests that int can be 64 bit. We don't care? So far the only compiler I know where this could happen is MSVC. Since we have an endless amount of GNUisms in all of our code that

Re: [coreboot] [PATCH] outb(* 0x80) to post_code()

2011-02-25 Thread Patrick Georgi
Am 25.02.2011 22:10, schrieb Stefan Reinauer: static inline void smbus_delay(void) { - outb(0x80, 0x80); + post_code(POST_SMBUS_DELAY); } This should not be an outb to 0x80 at all, as it does not reflect a post_code debug message but rather a delay. I suggest that you either use

Re: [coreboot] [PATCH 5/5] libpayload: Add more libpci-compatibility (#defines)

2011-02-25 Thread Patrick Georgi
Am 25.02.2011 21:45, schrieb Stefan Reinauer: Is there some (public) documentation on how to use flashrom as a payload, or is there a chance you could publish this? The basic use is to write your own frontend that uses flashrom's doit() function. From there, you're on your own (for now).

Re: [coreboot] [PATCH] outb(* 0x80) to post_code()

2011-02-25 Thread Patrick Georgi
Am 25.02.2011 22:45, schrieb Stefan Reinauer: Hm. If we touch it now, why not fix it so we don't have to care anymore? Some smbus drivers (like the ICH7 one) are using inb already, and it works fine. I didn't want to block this task because of that other one, it's great that Alexandru takes

Re: [coreboot] [PATCH] outb(* 0x80) to post_code()

2011-02-25 Thread Stefan Reinauer
* Patrick Georgi patr...@georgi-clan.de [110225 22:55]: Am 25.02.2011 22:45, schrieb Stefan Reinauer: Hm. If we touch it now, why not fix it so we don't have to care anymore? Some smbus drivers (like the ICH7 one) are using inb already, and it works fine. I didn't want to block this task

Re: [coreboot] [PATCH] outb(* 0x80) to post_code()

2011-02-25 Thread Alex G.
Hi Stefan and Patrick. I Just saw your emails. inb(0x80) or post_code(POST_SMBUS_DELAY): make up your minds :) Extra #include post_codes: *mrnuke starts chopping Can we put this in one file together with src/include/cpu/amd/geode_post_code.h Looks interesting. Looking into that. Using

Re: [coreboot] [PATCH] outb(* 0x80) to post_code()

2011-02-25 Thread Keith Hui
Message: 2 Date: Fri, 25 Feb 2011 19:48:24 +0200 From: Alex G. mr.nuke...@gmail.com To: coreboot@coreboot.org coreboot@coreboot.org Subject: Re: [coreboot] [PATCH] outb(* 0x80) to post_code() Message-ID: 4d67eb68.2090...@gmail.com Content-Type: text/plain; charset=iso-8859-1 Find attached

Re: [coreboot] [PATCH] outb(* 0x80) to post_code()

2011-02-25 Thread Stefan Reinauer
* Alex G. mr.nuke...@gmail.com [110225 23:26]: Hi Stefan and Patrick. I Just saw your emails. inb(0x80) or post_code(POST_SMBUS_DELAY): make up your minds :) The second one seems wrong. It's not a post_code, but a delay that happens to print some garbage on a post card. Changing that into

Re: [coreboot] [PATCH] disabling microcode update

2011-02-25 Thread xdrudis
This is the patch for option B. You may not be able to test it without my next patch. At least for me selectiong EXPERT in make menuconfig breaks the build. Next patch fixes it. Make patching cpu microcode optional (for experts). It's been requested to not link update_microcode.c in that case,

Re: [coreboot] [PATCH] disabling microcode update

2011-02-25 Thread xdrudis
This patch tries to fix compilation when you select EXPERT in make menuconfig. If I select Expert mode in make menuconfig I couldn't compile because it complained of 2 missing configuration constants. I hope this is the right solution, but haven't really checked that the related code in

Re: [coreboot] [PATCH] outb(* 0x80) to post_code()

2011-02-25 Thread Alex G.
Signed-off-by Alexandru Gagniuc mr.nuke...@gmail.com --- On 02/26/2011 02:58 AM, Stefan Reinauer wrote: Can we put this in one file together with [...] src/include/cpu/x86/post_code.h No. This would ruin the behavior of post_code() in console.c, which also outputs to console if the option

Re: [coreboot] [PATCH] disabling microcode update

2011-02-25 Thread Alex G.
On 02/26/2011 03:39 AM, xdrudis wrote: This patch tries to fix compilation when you select EXPERT in make menuconfig. HT Frequencies are multiples of 200MHz AFAIK, so there are no 300MHz and 500MHz. I'm not sure why the build breaks, and why this fixes it, but I don't think this is the right

Re: [coreboot] [PATCH] disabling microcode update

2011-02-25 Thread Alex G.
On 02/26/2011 03:38 AM, xdrudis wrote: This is the patch for option B. You may not be able to test it without my next patch. At least for me selectiong EXPERT in make menuconfig breaks the build. Next patch fixes it. I don't like the wording for the help option. It creates the

[coreboot] Intel's BIOS Implementation Test Suite

2011-02-25 Thread Andrew Guertin
I'm a lurker here (keep up the great work everyone! 3), but I saw this and thought it looked relevant to coreboot development that a link should be posted. http://biosbits.org/ Quoting from the website: The Intel BIOS Implementation Test Suite (BITS) provides a bootable pre-OS environment for