Hi,

Please find the latest report on new defect(s) introduced to coreboot found 
with Coverity Scan.

2 new defect(s) introduced to coreboot found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent 
build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1399151:  Integer handling issues  (DIVIDE_BY_ZERO)


________________________________________________________________________________________________________
*** CID 1399151:  Integer handling issues  (DIVIDE_BY_ZERO)
/src/vendorcode/cavium/bdk/libdram/lib_octeon_shared.c: 145 in 
init_octeon_dram_interface()
139     
140      restart_lmc_init:
141     
142         /* Poke the watchdog timer so it doesn't expire during DRAM init */
143         bdk_watchdog_poke();
144     
>>>     CID 1399151:  Integer handling issues  (DIVIDE_BY_ZERO)
>>>     In function call "init_octeon3_ddr3_interface", division by expression 
>>> "ddr_hertz" which may be zero has undefined behavior.
145         mem_size_mbytes = init_octeon3_ddr3_interface(node,
146                                                       ddr_configuration,
147                                                       ddr_hertz,
148                                                       cpu_hertz,
149                                                       ddr_ref_hertz,
150                                                       board_type,

** CID 1395725:  Control flow issues  (DEADCODE)
/src/mainboard/intel/coffeelake_rvp/romstage.c: 23 in 
mainboard_memory_init_params()


________________________________________________________________________________________________________
*** CID 1395725:  Control flow issues  (DEADCODE)
/src/mainboard/intel/coffeelake_rvp/romstage.c: 23 in 
mainboard_memory_init_params()
17     #include <baseboard/variants.h>
18     #include <soc/cnl_memcfg_init.h>
19     #include <soc/romstage.h>
20     
21     void mainboard_memory_init_params(FSPM_UPD *memupd)
22     {
>>>     CID 1395725:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "spd.spd_smbus_address[spd@d...".
23      const struct spd_info spd = {
24              .spd_smbus_address[0] = 0xA0,
25              .spd_smbus_address[1] = 0xA2,
26              .spd_smbus_address[2] = 0xA4,
27              .spd_smbus_address[3] = 0xA6,
28      };
29     
30      cannonlake_memcfg_init(&memupd->FspmConfig,
31                              variant_memcfg_config(), &spd);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbLuoVetFLSjdonCi1EjfHRqWGQvojmmkYaBE-2BPJiTQvaU4HClancRgJSp1vcdHRWU-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5Y7dkusFz04DFhJcyfznGrUxGIshFqhN1mQEwJtLOYgUjTvQfywYrN4kSeWVciJB6HFgAyNWHv4a1bcrekh52p7WGxDu0PtuV0jh-2Fypv-2FCDvE0sFhcFqhWi6cV7ahQvTMGsufCU9ON14YewdsUZc2SJ2BoFOEaKw-2BRc-2FsHNzeWAAUh6r1iC7AHtglmn4GiTurQ-3D
_______________________________________________
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org

Reply via email to