[coreboot] [coreboot - Cleanup #421] Change API of functions taking hash as an argument

2022-10-14 Thread Julius Werner
Issue #421 has been updated by Julius Werner. Can you explain what use case you have that requires you to use multiple algorithms? And why is it not enough to just call tpm_extend_pcr() several times, once for each algorithm? Let's clarify what your high-level goal here is first before we

[coreboot] [coreboot - Cleanup #421] Change API of functions taking hash as an argument

2022-10-14 Thread Sergii Dmytruk
Issue #421 has been updated by Sergii Dmytruk. If there are no objections, I'll use an API like this instead: ``` struct tpm_digest { const uint8_t *hash; size_t len; enum vb2_hash_algorithm hash_type; }; /** * Ask vboot for a digest and extend a TPM PCR with it. *

[coreboot] [coreboot - Feature #420] Use standard format of TPM event log

2022-10-14 Thread Michał Żygowski
Issue #420 has been updated by Michał Żygowski. Related links updated Michał Żygowski wrote in #note-10: > Adding subtask seems to be a new issue creation. In order to avoid > duplication, I have added these issues from related links to the Related > Issues section. NVM, I can assign

[coreboot] [coreboot - Documentation #426] Document existing and added TPM event log formats and PCR usage

2022-10-14 Thread Michał Żygowski
Issue #426 has been updated by Michał Żygowski. Parent task set to #420 Documentation #426: Document existing and added TPM event log formats and PCR usage https://ticket.coreboot.org/issues/426#change-1180 * Author: Krystian Hebel * Status:

[coreboot] [coreboot - Feature #425] Add parsing of new TPM event log formats to cbmem utility

2022-10-14 Thread Michał Żygowski
Issue #425 has been updated by Michał Żygowski. Parent task set to #420 Feature #425: Add parsing of new TPM event log formats to cbmem utility https://ticket.coreboot.org/issues/425#change-1179 * Author: Krystian Hebel * Status: New *

[coreboot] [coreboot - Feature #424] Create and implement option to choose either TCG or vboot PCR assignment

2022-10-14 Thread Michał Żygowski
Issue #424 has been updated by Michał Żygowski. Parent task set to #420 Feature #424: Create and implement option to choose either TCG or vboot PCR assignment https://ticket.coreboot.org/issues/424#change-1178 * Author: Krystian Hebel * Status:

[coreboot] [coreboot - Feature #423] Implement legacy and crypto agile TPM event log formats

2022-10-14 Thread Michał Żygowski
Issue #423 has been updated by Michał Żygowski. Parent task set to #420 Feature #423: Implement legacy and crypto agile TPM event log formats https://ticket.coreboot.org/issues/423#change-1177 * Author: Krystian Hebel * Status: New * Priority:

[coreboot] [coreboot - Feature #422] Create Kconfig menu for TPM event log format

2022-10-14 Thread Michał Żygowski
Issue #422 has been updated by Michał Żygowski. Parent task set to #420 Feature #422: Create Kconfig menu for TPM event log format https://ticket.coreboot.org/issues/422#change-1176 * Author: Krystian Hebel * Status: New * Priority: Normal *

[coreboot] [coreboot - Cleanup #421] Change API of functions taking hash as an argument

2022-10-14 Thread Michał Żygowski
Issue #421 has been updated by Michał Żygowski. Parent task set to #420 Cleanup #421: Change API of functions taking hash as an argument https://ticket.coreboot.org/issues/421#change-1175 * Author: Krystian Hebel * Status: New * Priority:

[coreboot] [coreboot - Feature #420] Use standard format of TPM event log

2022-10-14 Thread Michał Żygowski
Issue #420 has been updated by Michał Żygowski. Adding subtask seems to be a new issue creation. In order to avoid duplication, I have added these issues from related links to the Related Issues section. Feature #420: Use standard format of TPM

[coreboot] [coreboot - Feature #420] Use standard format of TPM event log

2022-10-14 Thread Michał Żygowski
Issue #420 has been updated by Michał Żygowski. Related to Documentation #426: Document existing and added TPM event log formats and PCR usage added Feature #420: Use standard format of TPM event log

[coreboot] [coreboot - Documentation #426] Document existing and added TPM event log formats and PCR usage

2022-10-14 Thread Michał Żygowski
Issue #426 has been updated by Michał Żygowski. Related to Feature #420: Use standard format of TPM event log added Documentation #426: Document existing and added TPM event log formats and PCR usage

[coreboot] [coreboot - Feature #425] Add parsing of new TPM event log formats to cbmem utility

2022-10-14 Thread Michał Żygowski
Issue #425 has been updated by Michał Żygowski. Related to Feature #420: Use standard format of TPM event log added Feature #425: Add parsing of new TPM event log formats to cbmem utility https://ticket.coreboot.org/issues/425#change-1171 *

[coreboot] [coreboot - Feature #420] Use standard format of TPM event log

2022-10-14 Thread Michał Żygowski
Issue #420 has been updated by Michał Żygowski. Related to Feature #425: Add parsing of new TPM event log formats to cbmem utility added Feature #420: Use standard format of TPM event log https://ticket.coreboot.org/issues/420#change-1170 *

[coreboot] [coreboot - Feature #424] Create and implement option to choose either TCG or vboot PCR assignment

2022-10-14 Thread Michał Żygowski
Issue #424 has been updated by Michał Żygowski. Related to Feature #420: Use standard format of TPM event log added Feature #424: Create and implement option to choose either TCG or vboot PCR assignment

[coreboot] [coreboot - Feature #420] Use standard format of TPM event log

2022-10-14 Thread Michał Żygowski
Issue #420 has been updated by Michał Żygowski. Related to Feature #424: Create and implement option to choose either TCG or vboot PCR assignment added Feature #420: Use standard format of TPM event log

[coreboot] [coreboot - Feature #423] Implement legacy and crypto agile TPM event log formats

2022-10-14 Thread Michał Żygowski
Issue #423 has been updated by Michał Żygowski. Related to Feature #420: Use standard format of TPM event log added Feature #423: Implement legacy and crypto agile TPM event log formats https://ticket.coreboot.org/issues/423#change-1167 * Author:

[coreboot] [coreboot - Feature #420] Use standard format of TPM event log

2022-10-14 Thread Michał Żygowski
Issue #420 has been updated by Michał Żygowski. Related to Feature #423: Implement legacy and crypto agile TPM event log formats added Feature #420: Use standard format of TPM event log https://ticket.coreboot.org/issues/420#change-1166 *

[coreboot] [coreboot - Cleanup #421] Change API of functions taking hash as an argument

2022-10-14 Thread Michał Żygowski
Issue #421 has been updated by Michał Żygowski. Related to Feature #420: Use standard format of TPM event log added Cleanup #421: Change API of functions taking hash as an argument https://ticket.coreboot.org/issues/421#change-1163 * Author:

[coreboot] [coreboot - Feature #422] Create Kconfig menu for TPM event log format

2022-10-14 Thread Michał Żygowski
Issue #422 has been updated by Michał Żygowski. Related to Feature #420: Use standard format of TPM event log added Feature #422: Create Kconfig menu for TPM event log format https://ticket.coreboot.org/issues/422#change-1165 * Author: Krystian

[coreboot] [coreboot - Feature #420] Use standard format of TPM event log

2022-10-14 Thread Michał Żygowski
Issue #420 has been updated by Michał Żygowski. Related to Feature #422: Create Kconfig menu for TPM event log format added Feature #420: Use standard format of TPM event log https://ticket.coreboot.org/issues/420#change-1164 * Author: Krystian

[coreboot] [coreboot - Feature #420] Use standard format of TPM event log

2022-10-14 Thread Michał Żygowski
Issue #420 has been updated by Michał Żygowski. Related to Cleanup #421: Change API of functions taking hash as an argument added Feature #420: Use standard format of TPM event log https://ticket.coreboot.org/issues/420#change-1162 * Author:

[coreboot] [coreboot - Feature #420] Use standard format of TPM event log

2022-10-14 Thread Michał Żygowski
Issue #420 has been updated by Michał Żygowski. Related links updated Arthur Heymans wrote in #note-2: > https://review.coreboot.org/c/coreboot/+/51710 Implements the TCG one. The > coreboot implementation is not a 'proprietary' format. That would imply that > there is a license

[coreboot] [coreboot - Bug #310] (Resolved) Coreboot 4.14 fails on a Lenvovo T440p

2022-10-14 Thread Angel Pons
Issue #310 has been updated by Angel Pons. Affected OS set to All (coreboot bug) Affected hardware set to ThinkPad T440p Status changed from Response Needed to Resolved Bug #310: Coreboot 4.14 fails on a Lenvovo T440p

[coreboot] [coreboot - Feature #420] Use standard format of TPM event log

2022-10-14 Thread Arthur Heymans
Issue #420 has been updated by Arthur Heymans. https://review.coreboot.org/c/coreboot/+/51710 Implements the TCG one. The coreboot implementation is not a 'proprietary' format. That would imply that there is a license restriction on using it which there is not. A lot of the TCG spec simply

[coreboot] [coreboot - Feature #425] Add parsing of new TPM event log formats to cbmem utility

2022-10-14 Thread Michał Żygowski
Issue #425 has been updated by Michał Żygowski. Related links updated I have already started some work for parsing TCG compliant event log from DRTM event log area reserved in cbmem. It should be relatively simple to propagate to other cbmem regions if needed. Relevant patchset linekd in

[coreboot] [coreboot - Bug #427] x200: Two battery charging issues

2022-10-14 Thread Akura Ryu
Issue #427 has been updated by Akura Ryu. Angel Pons wrote in #note-4: > Hi, > > Yes, the EC should be reset by unplugging all power supplies, as it loses > power. The RTC/CMOS battery shouldn't matter, but it would be a good idea to > disconnect it as well if it's easy to do so. I've

[coreboot] [coreboot - Bug #427] x200: Two battery charging issues

2022-10-14 Thread Angel Pons
Issue #427 has been updated by Angel Pons. Hi, Yes, the EC should be reset by unplugging all power supplies, as it loses power. The RTC/CMOS battery shouldn't matter, but it would be a good idea to disconnect it as well if it's easy to do so. Bug

[coreboot] [coreboot - Bug #427] x200: Two battery charging issues

2022-10-14 Thread Akura Ryu
Issue #427 has been updated by Akura Ryu. Angel Pons wrote in #note-2: > Could you please check if the "battery not charging" issues are still present > when *not* using any software to mess with the thresholds? To properly test, > please make sure the EC (Embedded Controller) gets reset:

[coreboot] [coreboot - Bug #427] x200: Two battery charging issues

2022-10-14 Thread Angel Pons
Issue #427 has been updated by Angel Pons. Could you please check if the "battery not charging" issues are still present when *not* using any software to mess with the thresholds? To properly test, please make sure the EC (Embedded Controller) gets reset: power off the laptop and remove all