Re: [coreboot] [PATCH][v3] Fintek F71805f improvements

2008-10-12 Thread ron minnich
On Sat, Oct 11, 2008 at 10:12 AM, Uwe Hermann <[EMAIL PROTECTED]> wrote: > OK for now, but maybe we can integrate this a bit more with the dts > later. > The easiest way to integrate stage1 and dts is carl-daniel's suggestion long ago to generate #defines from the dts for stage1. I don't think w

Re: [coreboot] [PATCH][v3] Fintek F71805f improvements

2008-10-12 Thread Corey Osgood
On Sat, Oct 11, 2008 at 1:12 PM, Uwe Hermann <[EMAIL PROTECTED]> wrote: > On Sat, Oct 11, 2008 at 12:42:43PM -0400, Corey Osgood wrote: > > Signed-off-by: Corey Osgood <[EMAIL PROTECTED]> > > Acked-by: Uwe Hermann <[EMAIL PROTECTED]> Committed (with some minor changes) in r917 > > Index: supe

Re: [coreboot] [PATCH][v3] Fintek F71805f improvements

2008-10-11 Thread Uwe Hermann
On Sat, Oct 11, 2008 at 12:42:43PM -0400, Corey Osgood wrote: > Signed-off-by: Corey Osgood <[EMAIL PROTECTED]> Acked-by: Uwe Hermann <[EMAIL PROTECTED]> > Index: superio/fintek/f71805f/stage1.c > === > --- superio/fintek/f71805f/s

Re: [coreboot] [PATCH][v3] Fintek F71805f improvements

2008-10-11 Thread ron minnich
apropos this: //init_uart8250(res0->base, &conf->sp2); it's in all the superios. The issue is that the name changed to: void uart8250_init(unsigned base_port, unsigned divisor, unsigned lcs) We should fix those up for all superios. Change it or not, either way: Acked-by: Ronald G

[coreboot] [PATCH][v3] Fintek F71805f improvements

2008-10-11 Thread Corey Osgood
See attached patch. Tested to build and work. Make some changes to the Fintek F71805f: * Read port for early serial console from Kconfig * Change naming from SP (serial port) to COM to be consistent with Kconfig Signed-off-by: Corey Osgood <[EMAIL PROTECTED]> Index: superio/fintek/f71805f/stage