Re: [coreboot] [PATCH] Avoid hang when 4GB or more DRAM is installed on AMD RS780 UMA systems

2010-11-11 Thread Scott Duplichan
-Original Message- From: coreboot-boun...@coreboot.org [mailto:coreboot-boun...@coreboot.org] On Behalf Of Liu Tao Sent: Thursday, November 11, 2010 03:32 AM To: Scott Duplichan Cc: coreboot@coreboot.org Subject: Re: [coreboot] [PATCH] Avoid hang when 4GB or more DRAM is installed on AMD

Re: [coreboot] [PATCH] Avoid hang when 4GB or more DRAM is installed on AMD RS780 UMA systems

2010-11-11 Thread Joseph Smith
On Wed, 10 Nov 2010 19:29:45 -0800, Stefan Reinauer wrote: > > > Sent from my mobile phone > > On 10.11.2010, at 17:36, Joseph Smith wrote: >> Not so sure about AMD chips but I know Intel chips reserve memory just > below 4Gb for vga buffer. As for resource ranges Intel chips reserve a low >

Re: [coreboot] [PATCH] Avoid hang when 4GB or more DRAM is installed on AMD RS780 UMA systems

2010-11-11 Thread Liu Tao
On 11/10/10, Scott Duplichan wrote: > Avoid hang when 4GB or more DRAM is installed on AMD RS780 UMA systems. > > -- When building for UMA, reduce the limit for DRAM below 4GB >from E000 to C000. This is needed to accomodate the >UMA frame buffer. > -- Correct problem where msr C00

Re: [coreboot] [PATCH] Avoid hang when 4GB or more DRAM is installed on AMD RS780 UMA systems

2010-11-10 Thread Stefan Reinauer
Sent from my mobile phone On 10.11.2010, at 17:36, Joseph Smith wrote: > Not so sure about AMD chips but I know Intel chips reserve memory just below > 4Gb for vga buffer. As for resource ranges Intel chips reserve a low memory > range for VESA IO registers and a high memory range for GMCH MM

Re: [coreboot] [PATCH] Avoid hang when 4GB or more DRAM is installed on AMD RS780 UMA systems

2010-11-10 Thread Joseph Smith
On 11/10/2010 07:30 PM, Scott Duplichan wrote: -Original Message- From: Joseph Smith [mailto:j...@settoplinux.org] Sent: Wednesday, November 10, 2010 05:42 PM To: Scott Duplichan Cc: 'Patrick Georgi'; coreboot@coreboot.org Subject: Re: [coreboot] [PATCH] Avoid hang when 4GB or

Re: [coreboot] [PATCH] Avoid hang when 4GB or more DRAM is installed on AMD RS780 UMA systems

2010-11-10 Thread Peter Stuge
Scott Duplichan wrote: > set_var_mtrr_resource is passed a range of c-7fff. The > existing coreboot code assumes this range has already had the UMA > part removed, and adds it back: > > // Increase the base range and set up UMA as an UC hole instead > var_state.range_sizek += (

Re: [coreboot] [PATCH] Avoid hang when 4GB or more DRAM is installed on AMD RS780 UMA systems

2010-11-10 Thread Scott Duplichan
-Original Message- From: Joseph Smith [mailto:j...@settoplinux.org] Sent: Wednesday, November 10, 2010 05:42 PM To: Scott Duplichan Cc: 'Patrick Georgi'; coreboot@coreboot.org Subject: Re: [coreboot] [PATCH] Avoid hang when 4GB or more DRAM is installed on AMD RS780 UMA syste

Re: [coreboot] [PATCH] Avoid hang when 4GB or more DRAM is installed on AMD RS780 UMA systems

2010-11-10 Thread Joseph Smith
On 11/10/2010 06:18 PM, Scott Duplichan wrote: ] On i945, UMA is done by providing a fixed resource. I don't think any ] other changes were necessary (see src/northbridge/intel/i945/northbridge.c) I took a look at the i945 code and found the AMD code also adds the exact same fixed resource for t

Re: [coreboot] [PATCH] Avoid hang when 4GB or more DRAM is installed on AMD RS780 UMA systems

2010-11-10 Thread Scott Duplichan
] On i945, UMA is done by providing a fixed resource. I don't think any ] other changes were necessary (see src/northbridge/intel/i945/northbridge.c) I took a look at the i945 code and found the AMD code also adds the exact same fixed resource for the UMA area. What I cannot figure out is how this

Re: [coreboot] [PATCH] Avoid hang when 4GB or more DRAM is installed on AMD RS780 UMA systems

2010-11-10 Thread Scott Duplichan
]Am 10.11.2010 18:43, schrieb Scott Duplichan: ]> Another possibility is to go back to the idea of one x86_setup_var_mtrrs ]> function. A new flag could be passed to x86_setup_var_mtrrs that tells ]> tells the function that it ius running on an AMD system. ]In that case, you could as well keep the

Re: [coreboot] [PATCH] Avoid hang when 4GB or more DRAM is installed on AMD RS780 UMA systems

2010-11-10 Thread Patrick Georgi
Am 10.11.2010 18:43, schrieb Scott Duplichan: > Another possibility is to go back to the idea of one x86_setup_var_mtrrs > function. A new flag could be passed to x86_setup_var_mtrrs that tells > tells the function that it ius running on an AMD system. In that case, you could as well keep the separ

Re: [coreboot] [PATCH] Avoid hang when 4GB or more DRAM is installed on AMD RS780 UMA systems

2010-11-10 Thread Scott Duplichan
-Original Message- From: coreboot-boun...@coreboot.org [mailto:coreboot-boun...@coreboot.org] On Behalf Of Patrick Georgi Sent: Wednesday, November 10, 2010 02:46 AM To: coreboot@coreboot.org Subject: Re: [coreboot] [PATCH] Avoid hang when 4GB or more DRAM is installed on AMD RS780 UMA

Re: [coreboot] [PATCH] Avoid hang when 4GB or more DRAM is installed on AMD RS780 UMA systems

2010-11-10 Thread Patrick Georgi
Am 10.11.2010 06:13, schrieb Scott Duplichan: > -- Split function x86_setup_var_mtrrs into standard and AMD versions. >The AMD version of the function relies on Tom2ForceMemTypeWB for >making DRAM above 4GB type WB. The AMD version also incorporates >a change to avoid an unexpected vari

[coreboot] [PATCH] Avoid hang when 4GB or more DRAM is installed on AMD RS780 UMA systems

2010-11-09 Thread Scott Duplichan
Avoid hang when 4GB or more DRAM is installed on AMD RS780 UMA systems. -- When building for UMA, reduce the limit for DRAM below 4GB from E000 to C000. This is needed to accomodate the UMA frame buffer. -- Correct problem where msr C0010010 bits 21 and 22 (MtrrTom2En and Tom2Forc