Re: [coreboot] [PATCH] Cleanup up HD audio codec / hda_verb.h files

2010-12-17 Thread Uwe Hermann
On Wed, Dec 15, 2010 at 09:02:16PM -0800, Stefan Reinauer wrote: > On 12/15/10 1:05 AM, Uwe Hermann wrote: > >>However, please refrain from removing the verb adding code from those > >>boards that actually have sound jacks. It makes no sense to remove the > >>codecs and add the same code later on.

Re: [coreboot] [PATCH] Cleanup up HD audio codec / hda_verb.h files

2010-12-15 Thread Stefan Reinauer
On 12/15/10 1:05 AM, Uwe Hermann wrote: However, please refrain from removing the verb adding code from those boards that actually have sound jacks. It makes no sense to remove the codecs and add the same code later on. Instead it should just be fixed as soon as the right information is known for

Re: [coreboot] [PATCH] Cleanup up HD audio codec / hda_verb.h files

2010-12-15 Thread Uwe Hermann
On Sat, Dec 11, 2010 at 01:29:09PM -0800, Stefan Reinauer wrote: > On 12/11/10 12:57 PM, Peter Stuge wrote: > > Uwe Hermann wrote: > >> Cleanup up HD audio codec / hda_verb.h files. > > .. > >> Signed-off-by: Uwe Hermann > > Acked-by: Peter Stuge Thanks, r6180. > However, please refrain from r

Re: [coreboot] [PATCH] Cleanup up HD audio codec / hda_verb.h files

2010-12-11 Thread Stefan Reinauer
Ooops that was intended for the list. On 12/11/10 12:21 PM, Stefan Reinauer wrote: > On 12/11/10 3:49 AM, Uwe Hermann wrote: >> The following files can be safely dropped as they don't match the ID >> of the audio codec and thus will never get actually used (you'll see >> "HDA: no verb!" or similar

Re: [coreboot] [PATCH] Cleanup up HD audio codec / hda_verb.h files

2010-12-11 Thread Stefan Reinauer
On 12/11/10 12:57 PM, Peter Stuge wrote: > Uwe Hermann wrote: >> Cleanup up HD audio codec / hda_verb.h files. > .. >> Signed-off-by: Uwe Hermann > Acked-by: Peter Stuge > However, please refrain from removing the verb adding code from those boards that actually have sound jacks. It makes no sens

Re: [coreboot] [PATCH] Cleanup up HD audio codec / hda_verb.h files

2010-12-11 Thread Peter Stuge
Uwe Hermann wrote: > Cleanup up HD audio codec / hda_verb.h files. .. > Signed-off-by: Uwe Hermann Acked-by: Peter Stuge -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot

[coreboot] [PATCH] Cleanup up HD audio codec / hda_verb.h files

2010-12-11 Thread Uwe Hermann
See patch. Most of the hda_verb.h files can be safely dropped as they're unused (and/or incorrect). I own the MSI MS-7260 and will provide a working hda_verb.h file for that at some later point, and also for my upcoming ASUS M2N-E port. Uwe. -- http://hermann-uwe.de | http://sigrok.org htt