Re: [coreboot] [PATCH] Dump some more registers for Winbond W83627DHG

2011-03-29 Thread Uwe Hermann
On Mon, Mar 28, 2011 at 09:48:43PM +0200, Prakash Punnoor wrote: This patch adds support for dumping registers of Nuvoton W83627DHG-P/-PT. Signed-off-by: Prakash Punnoor prak...@punnoor.de Thanks, committed as r6468, including the revert of the last patch. I cross-checked against the

Re: [coreboot] [PATCH] Dump some more registers for Winbond W83627DHG

2011-03-29 Thread Marc Jones
On Tue, Mar 29, 2011 at 6:03 AM, Uwe Hermann u...@hermann-uwe.de wrote: On Mon, Mar 28, 2011 at 09:48:43PM +0200, Prakash Punnoor wrote: This patch adds support for dumping registers of Nuvoton W83627DHG-P/-PT. Signed-off-by: Prakash Punnoor prak...@punnoor.de Thanks, committed as r6468,

Re: [coreboot] [PATCH] Dump some more registers for Winbond W83627DHG

2011-03-28 Thread Prakash Punnoor
Hi, On Monday 28 March 2011 19:46:08 Uwe Hermann wrote: Hi, On Fri, Mar 25, 2011 at 10:55:21AM -0600, Marc Jones wrote: Signed-off-by: Prakash Punnoor prak...@punnoor.de Thanks for the contribution and for the reminder. Acked-by: Marc Jones marcj...@gmail.com Yup, thanks!

Re: [coreboot] [PATCH] Dump some more registers for Winbond W83627DHG

2011-03-28 Thread Prakash Punnoor
Hi, On Monday 28 March 2011 21:08:54 Prakash Punnoor wrote: @Marc Please revert my patch in the meantime. Sorry for the confusion. So, here's the patch. I did following: I checked both datasheets side by side and added the differences to a copy of the original values. In fact - except the

[coreboot] [PATCH] Dump some more registers for Winbond W83627DHG

2011-03-11 Thread Prakash Punnoor
Hi, I noticed some registers of Winbond W83627DHG, which the datasheet mentions, were not dumped by superiotool. This patch adds those registers to the dump. Signed-off-by: Prakash Punnoor prak...@punnoor.de Index: util/superiotool/winbond.c