Re: [coreboot] [PATCH] Fam10 FIDVID in SVI 01/25

2011-02-27 Thread Marc Jones
On Thu, Feb 24, 2011 at 2:27 PM, xdrudis wrote: > On Thu, Feb 24, 2011 at 02:31:29PM +0100, Georgi, Patrick wrote: >> Am Donnerstag, den 17.02.2011, 07:35 +0100 schrieb xdrudis: >> > see patch >> Any opinion on these patches? Patch 1-8 seem to be refactorings only, >> and splitting functions into

Re: [coreboot] [PATCH] Fam10 FIDVID in SVI 01/25

2011-02-24 Thread xdrudis
On Thu, Feb 24, 2011 at 02:31:29PM +0100, Georgi, Patrick wrote: > Am Donnerstag, den 17.02.2011, 07:35 +0100 schrieb xdrudis: > > see patch > Any opinion on these patches? Patch 1-8 seem to be refactorings only, > and splitting functions into smaller logical units looks good to me, but > I'd like

Re: [coreboot] [PATCH] Fam10 FIDVID in SVI 01/25

2011-02-24 Thread Marc Jones
On Thu, Feb 24, 2011 at 6:31 AM, Georgi, Patrick wrote: > Am Donnerstag, den 17.02.2011, 07:35 +0100 schrieb xdrudis: >> see patch > Any opinion on these patches? Patch 1-8 seem to be refactorings only, > and splitting functions into smaller logical units looks good to me, but > I'd like to hear f

Re: [coreboot] [PATCH] Fam10 FIDVID in SVI 01/25

2011-02-24 Thread Georgi, Patrick
Am Donnerstag, den 17.02.2011, 07:35 +0100 schrieb xdrudis: > see patch Any opinion on these patches? Patch 1-8 seem to be refactorings only, and splitting functions into smaller logical units looks good to me, but I'd like to hear from someone deeper in the AMD code. Patrick -- Patrick Georgi S

[coreboot] [PATCH] Fam10 FIDVID in SVI 01/25

2011-02-16 Thread xdrudis
see patchPrepare for next patches (Improving BKDG implementation of P-states, CPU and northbridge frequency and voltage handling for Fam 10 in SVI mode). No change of behaviour intended. Refactor FAM10 fidvid . prep_fid_change was already long and it'd get longer with forthcoming patches. We now