Re: [coreboot] [PATCH] Fix compile failure when VGA_ROM_RUN disabled on epia-cn.

2011-01-17 Thread Kevin O'Connor
On Mon, Jan 17, 2011 at 05:37:45AM +0100, Peter Stuge wrote: Stefan Reinauer wrote: The cn700.c code references mainboard_interrupt_handlers() which isn't defined if VGA_ROM_RUN is off. Define a dummy implementation of that function for this case. Shouldn't cn700.c code be

Re: [coreboot] [PATCH] Fix compile failure when VGA_ROM_RUN disabled on epia-cn.

2011-01-17 Thread Peter Stuge
Kevin O'Connor wrote: We know that coreboot support for via hardware suffers from copypastitis. Would be good to unify that at some point, but for this patch I think the fix should go into the components that are affected, so that they don't use what isn't available. In this particular

[coreboot] [PATCH] Fix compile failure when VGA_ROM_RUN disabled on epia-cn.

2011-01-16 Thread Kevin O'Connor
The cn700.c code references mainboard_interrupt_handlers() which isn't defined if VGA_ROM_RUN is off. Define a dummy implementation of that function for this case. Signed-off-by: Kevin O'Connor ke...@koconnor.net --- src/arch/x86/include/arch/interrupt.h |4 1 files changed, 4

Re: [coreboot] [PATCH] Fix compile failure when VGA_ROM_RUN disabled on epia-cn.

2011-01-16 Thread Stefan Reinauer
* Kevin O'Connor ke...@koconnor.net [110116 18:59]: The cn700.c code references mainboard_interrupt_handlers() which isn't defined if VGA_ROM_RUN is off. Define a dummy implementation of that function for this case. Signed-off-by: Kevin O'Connor ke...@koconnor.net Acked-by: Stefan Reinauer

Re: [coreboot] [PATCH] Fix compile failure when VGA_ROM_RUN disabled on epia-cn.

2011-01-16 Thread Peter Stuge
Kevin O'Connor wrote: The cn700.c code references mainboard_interrupt_handlers() which isn't defined if VGA_ROM_RUN is off. Define a dummy implementation of that function for this case. Shouldn't cn700.c code be changed instead, so that it doesn't reference the function when VGA_ROM_RUN is

Re: [coreboot] [PATCH] Fix compile failure when VGA_ROM_RUN disabled on epia-cn.

2011-01-16 Thread Stefan Reinauer
* Peter Stuge pe...@stuge.se [110117 02:32]: Kevin O'Connor wrote: The cn700.c code references mainboard_interrupt_handlers() which isn't defined if VGA_ROM_RUN is off. Define a dummy implementation of that function for this case. Shouldn't cn700.c code be changed instead, so that it

Re: [coreboot] [PATCH] Fix compile failure when VGA_ROM_RUN disabled on epia-cn.

2011-01-16 Thread Peter Stuge
Stefan Reinauer wrote: The cn700.c code references mainboard_interrupt_handlers() which isn't defined if VGA_ROM_RUN is off. Define a dummy implementation of that function for this case. Shouldn't cn700.c code be changed instead, so that it doesn't reference the function when