This patch fixes the option rom code that was buggy when it switched segment
registers before restoring register values. This was breaking the Geode VSA,
and probably would have hurt other option roms as well.
Signed-off by: Edwin Beasant edwin_beas...@virtensys.com
---
coreboot-v4-vsa-fix.pa
Am Freitag, den 04.06.2010, 16:25 +0100 schrieb Edwin Beasant:
> This patch fixes the option rom code that was buggy when it switched
> segment registers before restoring register values. This was breaking
> the Geode VSA, and probably would have hurt other option roms as well.
>
>
>
> Signed-o
On 6/4/10 6:37 PM, Patrick Georgi wrote:
> Am Freitag, den 04.06.2010, 16:25 +0100 schrieb Edwin Beasant:
>
>> This patch fixes the option rom code that was buggy when it switched
>> segment registers before restoring register values. This was breaking
>> the Geode VSA, and probably would have h
I don't see where ax gets set to 0. Does the comment need to be updated, or
do you want all the segments set to ax?
+ /* initialize registers for option rom lcall */
+ movl__registers + 0, %eax
+ movl__registers + 4, %ebx
+ movl__registers + 8, %ecx
+
On 6/4/10 6:40 PM, Stefan Reinauer wrote:
> On 6/4/10 6:37 PM, Patrick Georgi wrote:
>
>> Am Freitag, den 04.06.2010, 16:25 +0100 schrieb Edwin Beasant:
>>
>>
>>> This patch fixes the option rom code that was buggy when it switched
>>> segment registers before restoring register values.
Hi all,
I boot tested the last revision (by Stefan) of this patch on my Wyse S50 (GX2)
and it seems to work nice!
So this patch is:
Acked-by: Nils Jacobs
Thanks,Nils.
--
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot
Edwin Beasant wrote:
> This patch fixes the option rom code that was buggy
Content-Description: coreboot-v4-vsa-fix.patch
> @@ -141,21 +146,25 @@
> mov %ax, %ds
> lidt__realmode_idt
>
> + /* initialize registers for option rom lcall */
> + movl__registers + 0, %e
On Fri, Jun 4, 2010 at 9:53 AM, Myles Watson wrote:
> mov $0, %ax
use the classic:
xorl %ax, %ax
ron
--
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot
[mailto:coreboot-bounces+edwin_beasant=virtensys@coreboot.org] On Behalf Of
ron minnich
Sent: 06 June 2010 05:50
To: Myles Watson
Cc: Stefan Reinauer; coreboot@coreboot.org
Subject: Re: [coreboot] [PATCH] Fix geode lx VSA loading
On Fri, Jun 4, 2010 at 9:53 AM, Myles Watson wrote:
> mov $0, %ax
oreboot@coreboot.org
> Subject: Re: [coreboot] [PATCH] Fix geode lx VSA loading
>
> On Fri, Jun 4, 2010 at 9:53 AM, Myles Watson wrote:
>
>
>> mov $0, %ax
>>
> use the classic:
> xorl %ax, %ax
>
> ron
>
> --
> coreboot mailing list: coreboot@corebo
ginal Message-
From: coreboot-boun...@coreboot.org [mailto:coreboot-boun...@coreboot.org] On
Behalf Of Stefan Reinauer
Sent: 07 June 2010 09:38
To: coreboot@coreboot.org
Subject: Re: [coreboot] [PATCH] Fix geode lx VSA loading
On 6/7/10 10:30 AM, Edwin Beasant wrote:
> Agreed - ax should be
11 matches
Mail list logo