Re: [coreboot] [PATCH] Hide CMOS_VSTART_ and CMOS_VLEN_ prefixes for read_option() use

2011-05-10 Thread Patrick Georgi
Am 11.05.2011 00:04, schrieb Stefan Reinauer: > Yes, given how complex most cmos.layouts look, I was surprised. > Is there an easy way to clean those cmos.layout files up? Obsolete build_opt_tbl by moving its functionality to nvramtool (that's WIP here), define a new format (eg. the one on Infrastr

Re: [coreboot] [PATCH] Hide CMOS_VSTART_ and CMOS_VLEN_ prefixes for read_option() use

2011-05-10 Thread Stefan Reinauer
* Patrick Georgi [110510 23:55]: > Am 10.05.2011 22:07, schrieb Stefan Reinauer: > >> Signed-off-by: Patrick Georgi > > Acked-by: Stefan Reinauer > r6565, thanks. thanks. > But yes, there aren't any more read_option uses. Probably a sign that > the nvram subsystem is underused? Yes, given ho

Re: [coreboot] [PATCH] Hide CMOS_VSTART_ and CMOS_VLEN_ prefixes for read_option() use

2011-05-10 Thread Patrick Georgi
Am 10.05.2011 22:07, schrieb Stefan Reinauer: >> Signed-off-by: Patrick Georgi > Acked-by: Stefan Reinauer r6565, thanks. >> 15 files changed, 24 insertions(+), 23 deletions(-) > Wow are those the only occurences of readoption in romstage code? read_option is used in romstage, get_option in ram

Re: [coreboot] [PATCH] Hide CMOS_VSTART_ and CMOS_VLEN_ prefixes for read_option() use

2011-05-10 Thread Stefan Reinauer
* Patrick Georgi [110510 21:23]: > [let's try again] > Hi, > > as a first step to the CMOS infrastructure project (as detailed in the > wiki), this patch changes read_option() by wrapping it in a macro, > simplifying its use from > read_option(CMOS_VSTART_foo, CMOS_VLEN_foo, somedefault) > to > r

[coreboot] [PATCH] Hide CMOS_VSTART_ and CMOS_VLEN_ prefixes for read_option() use

2011-05-10 Thread Patrick Georgi
[let's try again] Hi, as a first step to the CMOS infrastructure project (as detailed in the wiki), this patch changes read_option() by wrapping it in a macro, simplifying its use from read_option(CMOS_VSTART_foo, CMOS_VLEN_foo, somedefault) to read_option(foo, somedefault) Signed-off-by: Patric

Re: [coreboot] [PATCH] Hide CMOS_VSTART_ and CMOS_VLEN_ prefixes for read_option() use

2011-05-09 Thread Patrick Georgi
Am 09.05.2011 18:32, schrieb Paul Menzel: > did you change your mail setup? Somehow your message is not displayed > correctly, i. e. it is not formatted. Oops, I'll resend (that was with webmail stuff, and I rarely use the webmail with attachments) Thanks for the heads-up >> as a first step to th

Re: [coreboot] [PATCH] Hide CMOS_VSTART_ and CMOS_VLEN_ prefixes for read_option() use

2011-05-09 Thread Paul Menzel
Dear Patrick, Am Montag, den 09.05.2011, 17:08 +0200 schrieb Patrick Georgi: > Content-Type: text/plain; charset=UTF-8 > > Content-Transfer-Encoding: quoted-printable > =0D > Hi,=0D > =0D did you change your mail setup? Somehow your message is not displayed correctly, i. e. it is not formatted.

[coreboot] [PATCH] Hide CMOS_VSTART_ and CMOS_VLEN_ prefixes for read_option() use

2011-05-09 Thread Patrick Georgi
Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =0D Hi,=0D =0D as a first step to the CMOS infrastructure project (as detailed in the=0D wiki), this patch changes read_option() by wrapping it in a macro,=0D simplifying its use from=0D read_option(CMOS_VSTART_foo