Re: [coreboot] [PATCH] ICH5: Add i82801ex_enable_rom() function

2010-12-15 Thread Mark Marshall
On 15/12/2010 09:01, Uwe Hermann wrote: On Thu, Nov 25, 2010 at 08:42:54PM +0100, Uwe Hermann wrote: On Thu, Nov 25, 2010 at 10:50:19AM +, Mark Marshall wrote: All of the blocks of code you are removing to a config_u32 and a config_u8 write. The code you've added does a config_u32 and a co

Re: [coreboot] [PATCH] ICH5: Add i82801ex_enable_rom() function

2010-12-15 Thread Uwe Hermann
On Thu, Nov 25, 2010 at 08:42:54PM +0100, Uwe Hermann wrote: > On Thu, Nov 25, 2010 at 10:50:19AM +, Mark Marshall wrote: > > All of the blocks of code you are removing to a config_u32 and a > > config_u8 write. The code you've added does a config_u32 and a > > config_u16 write. Is this corre

Re: [coreboot] [PATCH] ICH5: Add i82801ex_enable_rom() function

2010-11-25 Thread Uwe Hermann
On Thu, Nov 25, 2010 at 10:50:19AM +, Mark Marshall wrote: > All of the blocks of code you are removing to a config_u32 and a > config_u8 write. The code you've added does a config_u32 and a > config_u16 write. Is this correct? Also the addresses that the > writes go to are different - the r

Re: [coreboot] [PATCH] ICH5: Add i82801ex_enable_rom() function

2010-11-25 Thread Mark Marshall
On 25/11/2010 09:11, Uwe Hermann wrote: See patch. Hi. All of the blocks of code you are removing to a config_u32 and a config_u8 write. The code you've added does a config_u32 and a config_u16 write. Is this correct? Also the addresses that the writes go to are different - the removed c

[coreboot] [PATCH] ICH5: Add i82801ex_enable_rom() function

2010-11-25 Thread Uwe Hermann
See patch. Uwe. -- http://hermann-uwe.de | http://sigrok.org http://randomprojects.org | http://unmaintained-free-software.org ICH5: Add i82801ex_enable_rom() function. Replace multiple custom instances in romstage.c files with one global i82801ex_enable_rom() function as the other chipsets