[coreboot] [PATCH] Make various DEBUG defines user-configurable in menuconfig

2009-10-20 Thread Uwe Hermann
See patch. Note that we need code-fixes for some chipsets and board when enabling some of the DEBUG options (my guess is that code was never tested much), but this is not related to my patch, those problems have been there already: - Some romcc boards throw "too few registers" errors if you enab

Re: [coreboot] [PATCH] Make various DEBUG defines user-configurable in menuconfig

2009-10-20 Thread Myles Watson
I like the idea of having Options that we use more available. DEBUG_SMI was the default. Now it isn't. DEBUG_RAM_SETUP was the default for i440bx & vx800 in the Kontron code, #if CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8 This never does anything, since 8 is SPEW. I think it's too dangerous to play w

Re: [coreboot] [PATCH] Make various DEBUG defines user-configurable in menuconfig

2009-10-21 Thread Uwe Hermann
On Tue, Oct 20, 2009 at 11:37:02AM -0600, Myles Watson wrote: > I like the idea of having Options that we use more available. > > DEBUG_SMI was the default. Now it isn't. > DEBUG_RAM_SETUP was the default for i440bx & vx800 True, but that's intentional. Just like the "use lzma" or "execute vga b

Re: [coreboot] [PATCH] Make various DEBUG defines user-configurable in menuconfig

2009-10-21 Thread Myles Watson
> On Tue, Oct 20, 2009 at 11:37:02AM -0600, Myles Watson wrote: > > I like the idea of having Options that we use more available. > > > > DEBUG_SMI was the default. Now it isn't. > > DEBUG_RAM_SETUP was the default for i440bx & vx800 > > True, but that's intentional. Just like the "use lzma" or "

Re: [coreboot] [PATCH] Make various DEBUG defines user-configurable in menuconfig

2009-10-21 Thread Uwe Hermann
On Wed, Oct 21, 2009 at 01:23:21PM -0600, Myles Watson wrote: > As long as all of the code that gets enabled/disabled is only print > statements, that's probably true. I was worried that some of these boards > may depend on the correct setting of those debug flags to be functional. I don't think

Re: [coreboot] [PATCH] Make various DEBUG defines user-configurable in menuconfig

2009-10-21 Thread Myles Watson
On Wed, Oct 21, 2009 at 3:04 PM, Uwe Hermann wrote: > On Wed, Oct 21, 2009 at 01:23:21PM -0600, Myles Watson wrote: > > As long as all of the code that gets enabled/disabled is only print > > statements, that's probably true. I was worried that some of these > boards > > may depend on the correc

Re: [coreboot] [PATCH] Make various DEBUG defines user-configurable in menuconfig

2009-10-22 Thread Stefan Reinauer
Myles Watson wrote: >>> Right now I'd like to match newconfig and kill it as >>> quickly as possible. >>> >> Sure, same here. I don't think this patch interferes with this effort >> though. >> > As long as all of the code that gets enabled/disabled is only print > statements, that's pro

Re: [coreboot] [PATCH] Make various DEBUG defines user-configurable in menuconfig

2009-10-22 Thread Myles Watson
> > As long as all of the code that gets enabled/disabled is only print > > statements, that's probably true. I was worried that some of these > boards > > may depend on the correct setting of those debug flags to be functional. > > > Which boards are that? There are lots of boards affected by thi